Add ability to select to install matching version already available on the current image#19
Open
nikolai-laevskii wants to merge 18 commits intomainfrom
Open
Add ability to select to install matching version already available on the current image#19nikolai-laevskii wants to merge 18 commits intomainfrom
nikolai-laevskii wants to merge 18 commits intomainfrom
Conversation
dsame
approved these changes
Sep 6, 2023
src/dotnet-utils.ts
Outdated
| * correct version number like '3.1.201', '3.1.201', '3.1.201', '3.1.201', '6.0.402' | ||
| */ | ||
| export const matchVersionToList = (version: string, versions: string[]) => { | ||
| if (!version || version === 'x' || version === '*') { |
There was a problem hiding this comment.
Is not version argument is semver specification and semver matcher package can be used in order to match? Also version can be renamed to versionSpec then.
Author
There was a problem hiding this comment.
This is a good point, but semver doesn't seem to work correctly with 6.0.4xx version format, i.e:
semver.satisfies('6.0.402', '6.0.4xx') // -> false (should be true)- add explicit return type for findMatching version function - force version argument to be defined in createVersionArgument - make dotnetVersion and quality properties readonly
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Adds ability to set preference for already installed versions when setting up dotnet environment. If
prefer-installedflag is active, action will attempt to check already installed versions with dotnet utility. If matching version exists on the runner, request for this specific version will be passed to the install-script, which has ability to verify already installed version and skip download if current installation is not broken.Related issue:
actions#356
Check list: