Skip to content

Sequence logging effects in S3Writer using flatTap and *> #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Copilot wants to merge 2 commits into from
Closed

Sequence logging effects in S3Writer using flatTap and *> #4

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5dee18a
Initial plan
Copilot Dec 29, 2025
73eb292
Fix logging effect sequencing in S3Writer
Copilot Dec 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
61 changes: 31 additions & 30 deletions src/main/scala/com/async2databricks/s3/S3Writer.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,21 +44,16 @@ object S3Writer extends CatsLogger {
.region(Region.of(config.region))

// Use custom endpoint for LocalStack
val client =
if (
config.endpoint.nonEmpty && config.endpoint != "https://s3.amazonaws.com"
) {
builder.endpointOverride(URI.create(config.endpoint)).build()
} else {
builder.build()
}

// Log effectfully
log.info(
s"S3 client created for endpoint: ${config.endpoint}"
) // Only for side-effect, not recommended in prod
client
}
if (
config.endpoint.nonEmpty && config.endpoint != "https://s3.amazonaws.com"
) {
builder.endpointOverride(URI.create(config.endpoint)).build()
} else {
builder.build()
}
}.flatTap(client =>
log.info(s"S3 client created for endpoint: ${config.endpoint}")
)
}(client => Async[F].delay(client.close()))
}

Expand All @@ -69,23 +64,29 @@ object S3Writer extends CatsLogger {
bucketName: String
): F[Unit] = {
val log = logger[F]
Async[F].delay {
try {
s3Client.headBucket(
HeadBucketRequest.builder().bucket(bucketName).build()
)
log.info(
s"Bucket $bucketName already exists"
) // Only for side-effect, not recommended in prod
} catch {
case _: NoSuchBucketException =>
log.info(s"Creating bucket $bucketName")
s3Client.createBucket(
CreateBucketRequest.builder().bucket(bucketName).build()
Async[F]
.delay {
try {
s3Client.headBucket(
HeadBucketRequest.builder().bucket(bucketName).build()
)
log.info(s"Bucket $bucketName created successfully")
Some(())
} catch {
case _: NoSuchBucketException => None
}
}
.flatMap {
case Some(_) =>
log.info(s"Bucket $bucketName already exists")
case None =>
log.info(s"Creating bucket $bucketName") *>
Async[F].delay(
s3Client.createBucket(
CreateBucketRequest.builder().bucket(bucketName).build()
)
) *>
log.info(s"Bucket $bucketName created successfully")
}
}
}

def apply[F[_]: Async](config: S3Config): Resource[F, S3Writer[F]] = {
Expand Down