feat: runtime reload of rules#33
Merged
Merged
Conversation
SIGHUP handler for reloading rules without restarting the dataplane. Stats thread re-parses the rules file, it builds a new rule table and per-worker stats arrays, then swaps the pointers with 1s grace period. Moved the rule table from stack to heap so we can free the old rule table and replace it with a new one. swap process: build new table -> update each worker's pointer -> sleep 1s (grace period) -> free old table. to test it:
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SIGHUP handler for reloading rules without restarting the dataplane. Stats thread re-parses the rules file, it builds a new rule table and per-worker stats arrays, then swaps the pointers with 1s grace period.
Moved the rule table from stack to heap so we can free the old rule table and replace it with a new one.
swap process: build new table -> update each worker's pointer -> sleep 1s (grace period) -> free old table.
to test it:
kill -HUP $(pidof upe)