Hooks rewrite#73
Closed
jsejcksn wants to merge 2 commits intoakiran:masterfrom
jsejcksn:hooks-rewrite
Closed
Conversation
Returns a memoized, functional component
Returns a memoized, functional component
Author
|
Closing as stale |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I purposefully:
because it appears that you want to maintain a level of backward compatibility for now. I have written the code in this PR so that when you decide to update this package to utilize React 16+ with hooks, you will have less work to do.
I tested the "main" version of the component with the current stable branch of React (16.9), and it works as before, with the improvement that it fixes #22 (like #66 does). I have not tested the "optimized" version.