Fix compatibility with React 0.13+ and React Router 1.x#38
Open
mhamann wants to merge 2 commits intoakiran:masterfrom
Open
Fix compatibility with React 0.13+ and React Router 1.x#38mhamann wants to merge 2 commits intoakiran:masterfrom
mhamann wants to merge 2 commits intoakiran:masterfrom
Conversation
|
Can this get pulled in please? |
|
What's up with this? Would like to see it pulled in. |
Author
|
Seems like the author has abandoned this project. @akiran are you maintaining this any longer? If so, could we get some attention here? |
Author
|
I believe this fork is the most up to date and maintained: https://github.com/valzav/react-foundation-apps |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upgraded React and React Router to the latest versions and then fixed the issues caused by the upgrades.
I also replaced the use of Bower by just grabbing Foundation for Apps from npm, which nicely tidies up the package management and simplifies things. Should also make life much easier if anyone wanted to use browserify (which struggles immensely with anything outside of the
node_modulesdir).Fixes #37, #28, #25, and #11.