fix: use of requestStreamParams middleware in streaming routes

[Sergejpm]

resolves panic when retrieving provider logs or kube events

[coderabbitai]

Walkthrough

The router configuration for lease event and log streaming endpoints was refactored to consolidate middleware usage. Middleware previously applied via separate subrouters is now combined into a single subrouter for each endpoint, streamlining the setup for /lease/<lease-id>/kubeevents and /lease/<lease-id>/logs.

Changes

File(s)	Change Summary
gateway/rest/router.go	Consolidated middleware application for lease event and log streaming endpoints into single subrouters

Poem

🐇
In the warren routes now run,
Middleware merged, two made one.
Logs and events, clear and neat,
Streamlined paths beneath our feet.
Router hops with nimble grace—
Simpler code, a tidier place!

---

📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 23e3ea9 and 0a4af39.

📒 Files selected for processing (1)

• gateway/rest/router.go (1 hunks)

🚧 Files skipped from review as they are similar to previous changes (1)

• gateway/rest/router.go

✨ Finishing Touches

• 📝 Generate Docstrings

🧪 Generate Unit Tests

• Create PR with Unit Tests
• Post Copyable Unit Tests in a Comment

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai auto-generate unit tests to generate unit tests for this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

🧹 Nitpick comments (1)

gateway/rest/router.go (1)

175-185: Factor the repeated “stream sub-router” setup into a helper for DRYness

The four-line pattern

mrouter = lrouter.NewRoute().Subrouter()
mrouter.Use(requestStreamParams, requireEndpointScopeForLeaseID(scope))

is duplicated for both the kubeevents and logs endpoints (and could appear again). Encapsulating it reduces duplication and keeps future middleware tweaks in one place:

+func leaseStreamSubrouter(parent *mux.Router, scope ajwt.PermissionScope) *mux.Router {
+    sr := parent.NewRoute().Subrouter()
+    sr.Use(requestStreamParams, requireEndpointScopeForLeaseID(scope))
+    return sr
+}
...
- mrouter = lrouter.NewRoute().Subrouter()
- mrouter.Use(requestStreamParams, requireEndpointScopeForLeaseID(ajwt.PermissionScopeEvents))
+ mrouter = leaseStreamSubrouter(lrouter, ajwt.PermissionScopeEvents)
...
- mrouter = lrouter.NewRoute().Subrouter()
- mrouter.Use(requestStreamParams, requireEndpointScopeForLeaseID(ajwt.PermissionScopeLogs))
+ mrouter = leaseStreamSubrouter(lrouter, ajwt.PermissionScopeLogs)

📜 Review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 71fb08c and d269512.

📒 Files selected for processing (1)

• gateway/rest/router.go (1 hunks)

🔇 Additional comments (1)

gateway/rest/router.go (1)

175-176: requestStreamParams now wired-in – panic fixed

Adding the middleware directly on the same sub-router as the permission check guarantees the query-parsing happens before the handler is hit, eliminating the nil-assertion panic that motivated the PR.

[troian]

thanks, can you please:
[ ] - format commit according to conventional commits spec
[ ] - create issue in https://github.com/akash-network/support and move stacktrace with panic over there
[ ] - reference issue in this PR

[vertex451]

@Sergejpm Please, resolve merge conflicts and I will promote your PR to the main branch.