Skip to content

fix(ios): replace BOOL* with NSNumber* to fix crash on RN 0.84+ (New … #295

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
giftsets wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix(ios): replace BOOL* with NSNumber* to fix crash on RN 0.84+ (New … #295

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion android/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ def safeExtGet(prop, fallback) {

buildscript {
repositories {
jcenter()
mavenCentral()
}

dependencies {
Expand Down
16 changes: 8 additions & 8 deletions ios/TextToSpeech/TextToSpeech.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,11 +94,11 @@ + (BOOL)requiresMainQueueSetup
resolve([NSNumber numberWithUnsignedLong:utterance.hash]);
}

RCT_EXPORT_METHOD(stop:(BOOL *)onWordBoundary resolve:(RCTPromiseResolveBlock)resolve reject:(__unused RCTPromiseRejectBlock)reject)
RCT_EXPORT_METHOD(stop:(NSNumber *)onWordBoundary resolve:(RCTPromiseResolveBlock)resolve reject:(__unused RCTPromiseRejectBlock)reject)
{
AVSpeechBoundary boundary;

if(onWordBoundary != NULL && onWordBoundary) {
if(onWordBoundary != nil && [onWordBoundary boolValue]) {
boundary = AVSpeechBoundaryWord;
} else {
boundary = AVSpeechBoundaryImmediate;
Expand All @@ -109,11 +109,11 @@ + (BOOL)requiresMainQueueSetup
resolve([NSNumber numberWithBool:stopped]);
}

RCT_EXPORT_METHOD(pause:(BOOL *)onWordBoundary resolve:(RCTPromiseResolveBlock)resolve reject:(__unused RCTPromiseRejectBlock)reject)
RCT_EXPORT_METHOD(pause:(NSNumber *)onWordBoundary resolve:(RCTPromiseResolveBlock)resolve reject:(__unused RCTPromiseRejectBlock)reject)
{
AVSpeechBoundary boundary;

if(onWordBoundary != NULL && onWordBoundary) {
if(onWordBoundary != nil && [onWordBoundary boolValue]) {
boundary = AVSpeechBoundaryWord;
} else {
boundary = AVSpeechBoundaryImmediate;
Expand All @@ -132,13 +132,13 @@ + (BOOL)requiresMainQueueSetup
}


RCT_EXPORT_METHOD(setDucking:(BOOL *)ducking
RCT_EXPORT_METHOD(setDucking:(NSNumber *)ducking
resolve:(RCTPromiseResolveBlock)resolve
reject:(__unused RCTPromiseRejectBlock)reject)
{
_ducking = ducking;
_ducking = ducking != nil ? [ducking boolValue] : NO;

if(ducking) {
if(_ducking) {
AVAudioSession *session = [AVAudioSession sharedInstance];
[session setCategory:AVAudioSessionCategoryPlayback
withOptions:AVAudioSessionCategoryOptionDuckOthers
Expand Down Expand Up @@ -178,7 +178,7 @@ + (BOOL)requiresMainQueueSetup
}

RCT_EXPORT_METHOD(setDefaultRate:(float)rate
skipTransform:(BOOL *)skipTransform // not used, compatibility with Android native module signature
skipTransform:(NSNumber *)skipTransform // not used, compatibility with Android native module signature
resolve:(RCTPromiseResolveBlock)resolve
reject:(RCTPromiseRejectBlock)reject)
{
Expand Down