ENG-2836 Agent cloning introduced#847
Merged
aix-ahmet merged 5 commits intodevelopmentfrom Mar 26, 2026
Merged
Conversation
aix-ahmet
reviewed
Mar 10, 2026
| result.status = AssetStatus.DRAFT | ||
| return None | ||
|
|
||
| def duplicate(self, clone_subagents: bool = False, name: Optional[str] = None) -> "Agent": |
Collaborator
There was a problem hiding this comment.
duplicate() bypasses the hook system -- after_clone is dead code
duplicate() method doesn't use the @with_hooks decorator, so this hook will never fire. Additionally, even if @with_hooks were added, the decorator infers the operation name from the function name -- it would look for before_duplicate / after_duplicate, not after_clone. So either:
- The method should be named clone() (matching the hook), or
- The hook should be renamed to after_duplicate, or
- The hook should be removed if it's not needed.
aix-ahmet
reviewed
Mar 10, 2026
aix-ahmet
reviewed
Mar 10, 2026
aix-ahmet
reviewed
Mar 10, 2026
Collaborator
aix-ahmet
left a comment
aix-ahmet
left a comment
There was a problem hiding this comment.
Please resolve the comments.
… naming Backend payload key remains "cloneSubagents" as required by the API.
aix-ahmet
approved these changes
Mar 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.