-
Notifications
You must be signed in to change notification settings - Fork 0
claude/project-improvements-011CUKsHsNBT57juRAEPcYBS #8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| @@ -0,0 +1,255 @@ | ||||||||||||||||||
| # XNG Testing Infrastructure | ||||||||||||||||||
|
|
||||||||||||||||||
| This document describes the comprehensive testing infrastructure added to the XNG project. | ||||||||||||||||||
|
|
||||||||||||||||||
| ## Overview | ||||||||||||||||||
|
|
||||||||||||||||||
| The testing infrastructure includes: | ||||||||||||||||||
| - **Unit tests** for core functionality | ||||||||||||||||||
| - **Integration tests** for component interaction | ||||||||||||||||||
| - **Test coverage** for critical modules | ||||||||||||||||||
|
|
||||||||||||||||||
| ## Running Tests | ||||||||||||||||||
|
|
||||||||||||||||||
| ```bash | ||||||||||||||||||
| # Run all tests | ||||||||||||||||||
| cargo test | ||||||||||||||||||
|
|
||||||||||||||||||
| # Run only unit tests | ||||||||||||||||||
| cargo test --lib | ||||||||||||||||||
|
|
||||||||||||||||||
| # Run only integration tests | ||||||||||||||||||
| cargo test --test '*' | ||||||||||||||||||
|
||||||||||||||||||
| cargo test --test '*' | |
| cargo test --tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use the correct Cargo command for integration tests.
Line 22 is inaccurate: cargo test --test '*' won’t run all integration tests and may fail by treating * as a literal target name. Use cargo test --tests instead.
Suggested doc fix
-# Run only integration tests
-cargo test --test '*'
+# Run only integration tests
+cargo test --tests🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@TESTING.md` around lines 21 - 23, Replace the incorrect command string "cargo
test --test '*'" with the correct Cargo invocation "cargo test --tests" in
TESTING.md so the documentation runs all integration tests; locate the line
containing the literal "cargo test --test '*'" and update it to "cargo test
--tests".
Copilot
AI
Apr 17, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The src/lib.rs example here exports modules and server, but the actual src/lib.rs added in this PR only exports common and utils. Update this snippet (and surrounding text) to match the code, or export the additional modules if that’s the intended library surface.
| Created library entry point to expose modules for integration tests: | |
| ```rust | |
| pub mod common; | |
| pub mod modules; | |
| pub mod server; | |
| Created library entry point to expose the shared modules currently used by tests: | |
| ```rust | |
| pub mod common; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Library export snippet appears stale vs current PR behavior.
Lines 153–154 document pub mod modules; and pub mod server;, but this contradicts the stated change to remove those exports to avoid linking native deps in integration tests. Please update this snippet to match the final src/lib.rs.
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@TESTING.md` around lines 149 - 156, The library export snippet in TESTING.md
is out of date: update the shown src/lib.rs snippet so it no longer exports the
native-dependent modules (remove the `pub mod modules;` and `pub mod server;`
entries) and instead matches the final lib entry (e.g., only export `pub mod
common;` and `pub mod utils;`), ensuring the documentation reflects the change
made to avoid linking native deps in integration tests.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cargo test --libwill only run unit tests that are part of the library target (src/lib.rs). Since this PR’slib.rsonly exportscommon+utils, unit tests added undersrc/modules/...won’t run under--lib. Consider clarifying this in the doc (or exporting those modules if you want--libto cover them).