Bk/performance optimizations#158
Open
bryankeller wants to merge 5 commits into
Open
Conversation
bryankeller
force-pushed
the
bk/performance-optimizations
branch
from
c247a87 to
0f9d900
Compare
bryankeller
force-pushed
the
bk/performance-optimizations
branch
from
c479981 to
90f58eb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Details
This is the first of two PRs to optimize MagazineLayout. I did extensive profiling, and found several hot spots.
For a collection view with 100,000 items in it, after this wave of optimizations, the time in
preparehas dropped by up to 12x.prepare, when theprepareModeisrebuildSectionModels: 59ms -> 5msprepare, when thenprepareModeisupdateLayoutMetrics: 58ms -> 15msHow Has This Been Tested
Tested in demo app and Airbnb app. Additionally, all unit tests pass.
Types of changes