Fix Windows localhost resolution without active network#12700
Draft
oppnc wants to merge 1 commit into
Draft
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #12700 +/- ##
=======================================
Coverage 98.95% 98.95%
=======================================
Files 131 131
Lines 46688 46733 +45
Branches 2421 2423 +2
=======================================
+ Hits 46200 46245 +45
Misses 366 366
Partials 122 122
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Merging this PR will not alter performance
Comparing Footnotes
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What do these changes do?
Adds a Windows
localhostfallback for resolver lookups that first fail withAI_ADDRCONFIG, retrying without the flag for both the threaded and async resolvers.Are there changes in behavior for the user?
Yes. Windows users can resolve
localhostwhile disconnected from active networks when the initialAI_ADDRCONFIGlookup fails.Is it a substantial burden for the maintainers to support this?
No. The fallback is scoped to Windows
localhost, only runs after the existing lookup fails, and is covered by resolver tests.Related issue number
Fixes #5357
Checklist
CONTRIBUTORS.txtCHANGES/folderValidation:
PYTHONPATH=. AIOHTTP_NO_EXTENSIONS=1 pytest tests/test_resolver.py -qpython -m black --check aiohttp/resolver.py tests/test_resolver.pypython -m flake8 aiohttp/resolver.py tests/test_resolver.py