zstd multi-frame streaming decompression in client payload#12266
Open
rootvector2 wants to merge 5 commits intoaio-libs:masterfrom
Open
zstd multi-frame streaming decompression in client payload#12266rootvector2 wants to merge 5 commits intoaio-libs:masterfrom
rootvector2 wants to merge 5 commits intoaio-libs:masterfrom
Conversation
for more information, see https://pre-commit.ci
psf-chronographer
bot
added
the
bot:chronographer:provided
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
❌ 2 Tests Failed:
View the top 2 failed test(s) by shortest run time
To view more test analytics, go to the Test Analytics Dashboard |
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What do these changes do?
Fix zstd decompression for HTTP responses containing multiple frames (e.g. chunked transfer).
The decompressor is reset on frame EOF to correctly handle subsequent frames.
Adds a loop-safety guard to prevent stalled
unused_datafrom causing infinite loops.Includes tests for multi-frame, partial-frame, and adversarial cases.
Are there changes in behavior for the user?
Yes, previously valid zstd-encoded responses with multiple frames could raise
ClientPayloadError.These responses are now correctly decoded.
No changes to gzip, deflate, or brotli behavior.
Is it a substantial burden for the maintainers to support this?
No.
The change is limited to zstd decompression logic, follows existing patterns, and includes tests covering edge cases.
It does not introduce new APIs or long-term maintenance overhead.
Related issue number
Fixes #12234
Checklist
CONTRIBUTORS.txtCHANGES/folder