perf: use deque for FormData.add_fields() queue#12166
Open
giulio-leone wants to merge 1 commit intoaio-libs:masterfrom
Open
perf: use deque for FormData.add_fields() queue#12166giulio-leone wants to merge 1 commit intoaio-libs:masterfrom
giulio-leone wants to merge 1 commit intoaio-libs:masterfrom
Conversation
add_fields() drains a work-list via .pop(0) and may grow it with .extend() when MultiDict entries are encountered (BFS pattern). Each .pop(0) is O(n); switching to collections.deque with .popleft() gives O(1) front removal. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replace
list.pop(0)withcollections.deque.popleft()inFormData.add_fields().Problem
add_fields()uses a work-list that drains from the front via.pop(0)and may grow via.extend()whenMultiDictentries are encountered (BFS pattern). Eachlist.pop(0)is O(n) because CPython must shift all remaining elements.Solution
Switch from
listtocollections.dequeand use.popleft()for O(1) front removal.Compatibility
.extend(), truthiness, and iteration are identical ondequeComplexity