Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes a Windows-specific ACP failure where Stage SYNTHESIS and other long-context stages could fail with an error
equivalent to "The command line is too long".
The issue was not token exhaustion. It was caused by prompt text being passed inline through the ACP CLI on Windows.
Root cause
On Windows,
acpxoften resolves to an npm-installed.cmdlauncher such asacpx.CMD.That launcher goes through
cmd.exe, which has a much smaller practical command-line limit than the normal Windowsprocess limit. As a result, prompts that were still below the previous inline threshold could still fail before the
existing fallback logic had a chance to help.
What changed
.cmdor.batwrapper.cmdACP launchers using the lower safe inline limitWhy this helps
This makes ACP prompt handling match the real behavior of Windows launcher wrappers instead of assuming the higher
process-level limit is always usable.
That prevents failures in stages that assemble large literature or synthesis context, especially when using Codex
CLI / Gemini CLI through npm-installed ACP commands.
Validation
for the actual
.cmdlauncher path