-
Notifications
You must be signed in to change notification settings - Fork 4
Fix multi-file DICOM pyramids leading to failed items for lower-res files #270
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 14 commits
Commits
Show all changes
24 commits
Select commit
Hold shift + click to select a range
9e89446
Add mpp correction factor and highest res .dcm selection.
blanca-pablos 55c4343
Update wsi info command in README
blanca-pablos 7fa9997
Merge branch 'main' into fix/legacy-mpp-multiple-dcm-files
helmut-hoffer-von-ankershoffen 8f9c048
Merge branch 'main' into fix/legacy-mpp-multiple-dcm-files
blanca-pablos d13b8a1
Add tests for DCM pyramid selection
blanca-pablos ed6d28e
Fix mpp factor being applied to DICOM
blanca-pablos fc728b5
Remove line recalculating mpp factor
blanca-pablos 477333d
Make variable lowercase to pass ruff
blanca-pablos 9d08efd
docs(wsi): Update with DICOM filtering logic.
blanca-pablos e03e722
fix(application): Fix wrong image size in multi-file DICOM filtering.
blanca-pablos d17fdcd
fix(wsi): Revert changes to apply MPP factor, not in scope.
blanca-pablos 98179aa
fix(application): Lint
blanca-pablos ea448b2
Merge branch 'main' into fix/legacy-mpp-multiple-dcm-files
helmut-hoffer-von-ankershoffen ec0c6de
fix(application): Filter out non-WSI .dcm files
blanca-pablos 291f1e6
task(application): Address Oliver's review.
blanca-pablos 326dfa6
task(wsi): Move DICOM filtering logic to pydicom handler, align CLI.
blanca-pablos fa54a37
task(docs): Update docs after move to WSI
blanca-pablos 5adaeee
task(testing): Clean up redundant tests
blanca-pablos a8729c4
Merge branch 'main' into fix/legacy-mpp-multiple-dcm-files
helmut-hoffer-von-ankershoffen 97c5bfe
chore(wsi): Refactor scan_files to pass SonarCloud complexity check
blanca-pablos ec357f8
Merge branch 'main' into fix/legacy-mpp-multiple-dcm-files
olivermeyer 2a83702
Merge branch 'main' into fix/legacy-mpp-multiple-dcm-files
blanca-pablos a13ce8b
fix(wsi): Remove PydicomHandler dependency from dcm file scanning
blanca-pablos dedb618
Update doc
blanca-pablos File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is somewhat inefficient:
Instead we could have a single function which lists files in the directory and returns only those to include, and iterate over that?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yep fair, I thought it would be a bit of a cleaner separation this way and anyways for typical dataset sizes time savings on
globwould be negligible, but agree 👍 refactored!