Merged
Conversation
Co-authored-by: Dominic Reber <dominic@aica.tech>
Co-authored-by: Dominic Reber <dominic@aica.tech>
Author
|
Anything else left to do here @domire8 ? |
SprGrf
commented
Feb 16, 2026
domire8
reviewed
Feb 17, 2026
Member
domire8
left a comment
domire8
left a comment
There was a problem hiding this comment.
A few nitpicks, two options:
- separate PR
- Apply them here and then rewrite the history of the branch to include them in the previous PR
This is such that we can use the Rebase and merge option on this PR that we like to use when we have staging branches.
source/modulo_components/include/modulo_components/ComponentInterface.hpp
Outdated
Show resolved
Hide resolved
source/modulo_components/include/modulo_components/ComponentInterface.hpp
Outdated
Show resolved
Hide resolved
source/modulo_components/modulo_components/component_interface.py
Outdated
Show resolved
Hide resolved
source/modulo_components/modulo_components/component_interface.py
Outdated
Show resolved
Hide resolved
source/modulo_components/modulo_components/component_interface.py
Outdated
Show resolved
Hide resolved
source/modulo_components/modulo_components/component_interface.py
Outdated
Show resolved
Hide resolved
domire8
previously approved these changes
Feb 17, 2026
Member
domire8
left a comment
domire8
left a comment
There was a problem hiding this comment.
Looks good to me, nice first big contribution to modulo!
domire8
reviewed
Feb 17, 2026
Closed
SprGrf
force-pushed
the
staging/assignments
branch
from
73e0e0e to
bb9a517
Compare
domire8
approved these changes
Feb 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Merging assignment definitions to main.
Review guidelines
Estimated Time of Review: 5 minutes
Checklist before merging: