docs: misc cleanup for agents#9502
Conversation
WalkthroughThis PR updates the HiCache documentation to reflect tier-aware shared KV cache routing and refines operational guidance. The sglang-hicache.md file is updated with clarified tier-aware event transitions, configuration flags, worked examples, and expanded verification/troubleshooting metrics. The navigation config removes a deprecated agentic workloads link. ChangesHiCache Documentation and Navigation
🎯 1 (Trivial) | ⏱️ ~3 minutes 🚥 Pre-merge checks | ✅ 3 | ❌ 2❌ Failed checks (1 warning, 1 inconclusive)
✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@docs/backends/sglang/sglang-hicache.md`:
- Around line 61-69: The doc uses two different medium labels (`CPU` in the
transition table vs `CPU_PINNED` in the verification example), causing
confusion; choose a single canonical label (e.g., replace all occurrences of
`CPU` in the transition table with `CPU_PINNED` or vice versa) and update every
emitted-event example (e.g., `store(CPU)`, `remove(CPU)`) to match the canonical
label, or alternatively add one clear note mapping `CPU` ↔ `CPU_PINNED` and
reference it where events are listed (ensure `store(CPU)`/`remove(CPU)` and the
verification example use the same term).
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 6ea54e43-8ce4-4d30-833a-7485e87eedc5
📒 Files selected for processing (2)
docs/backends/sglang/sglang-hicache.mddocs/index.yml
💤 Files with no reviewable changes (1)
- docs/index.yml
dynamo-ops
left a comment
There was a problem hiding this comment.
docs/index.yml — This navigation entry still points to the deleted docs/integrations/sglang-hicache.md path, so the HiCache page will be broken in the docs. Fix: update it and other inbound links to backends/sglang/sglang-hicache.md or keep a stub/redirect at the old path.
- agent-tracing.md: wrap "ATIF alignment" in <details>/<summary>; stray closing tags broke Fern's MDX parser. - sglang-hicache.md: use `CPU_PINNED` consistently to match the value SGLang's HiRadixCache actually emits (per CodeRabbit feedback). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Introduces docs/agents/pi-mono.md as the end-to-end "actually try agent tracing" page, backed by the pi-dynamo-provider extension. Nav entry added under User Guides > Agents. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Summary by CodeRabbit