[AAASM-4193] 📝 (docs): Complete the deploy.yml→aggregate.yml rename across all files#58
Open
Chisanan232 wants to merge 4 commits into
Open
[AAASM-4193] 📝 (docs): Complete the deploy.yml→aggregate.yml rename across all files#58Chisanan232 wants to merge 4 commits into
Chisanan232 wants to merge 4 commits into
Conversation
Complete the deploy.yml→aggregate.yml rename (incomplete fix of AAASM-4174): repoint the 404ing workflow link and the dir-tree comment to the actual aggregate.yml workflow. Refs AAASM-4193 Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01R7vqjjo5nrebYNt8WnCNbz
Repoint the two mermaid nodes and three 404ing links describing the current build+deploy workflow to aggregate.yml. Refs AAASM-4193 Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01R7vqjjo5nrebYNt8WnCNbz
…te.yml Repoint the source-of-truth workflow name to aggregate.yml and rewrite the stale 'CI is path-scoped' gotcha: aggregate.yml has no path filter, so every push/PR to main (plus workflow_dispatch) runs the full workflow — a .claude/-only change is now CI-gated, not review-only. Refs AAASM-4193 Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01R7vqjjo5nrebYNt8WnCNbz
… 0.5.x The live 'CI deploys today' pointer referenced the deleted deploy.yml and the old 0.4.x version; aggregate.yml pins mdBook 0.5.2, so update both the filename and the CI/local version note to match reality. Refs AAASM-4193 Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01R7vqjjo5nrebYNt8WnCNbz
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Completes the
deploy.yml→aggregate.ymlworkflow rename across the repo. The workflow was renamed (onlyaggregate.ymlexists in.github/workflows/;deploy.ymlis deleted), but AAASM-4174 fixed the README only — the sibling docs still pointed at the deleted file, producing 404 links on GitHub and wrong agent guidance. This is the same missed-sibling / incomplete-class-fix pattern.Doc/text change only — no code behavior changes.
Type of Change
Related Issues
What changed
Full grep-sweep (
grep -rn 'deploy\.yml' . --exclude-dir=.git --exclude-dir=book).Before (13 hits) → fixed (11):
CONTRIBUTING.md:5aggregate.ymlCONTRIBUTING.md:38aggregate.ymldocs/sync-architecture.md:24aggregate.ymldocs/sync-architecture.md:35aggregate.ymldocs/sync-architecture.md:97aggregate.ymldocs/sync-architecture.md:107aggregate.ymldocs/sync-architecture.md:168aggregate.yml.claude/CLAUDE.md:6aggregate.yml.claude/CLAUDE.md:91-92docs/theme/light-dark-toggle.js:12aggregate.yml+ versionCLAUDE.md trigger description — verified, not guessed.
aggregate.ymlhas nopaths:filter; it triggers onpush/pull_requesttomainplusworkflow_dispatch. The old gotcha claimed "CI is path-scoped … a.claude/-only change runs no CI" — now false. Rewrote it to state every push/PR tomainruns the full workflow.light-dark-toggle.js: the comment was a live pointer ("CI deploys 0.4.x today") —
aggregate.ymlpins mdBook 0.5.2, so both the filename and the stale 0.4.x/0.5.x CI-vs-local note were corrected to match reality.Intentionally left (2) — historical/legacy references; renaming would make them factually false:
AGGREGATION.md:149deploy.yml, no aggregation".github/workflows/aggregate.yml:42deploy.ymlcannot render it"Both are
docs/book/build-output duplicates aside — that dir is.gitignored and not committed.How to verify
cd docs && mdbook build— passes (only the benign mdbook-mermaid 0.5.0-vs-0.5.2 build-version warning).grep -rn 'deploy\.yml' . --exclude-dir=.git --exclude-dir=book— only the 2 intentional historical refs above remain; every live docs-workflow reference now points ataggregate.yml, and.github/workflows/aggregate.ymlexists so the links resolve.Documentation Checklist
cd docs && mdbook buildpasses locally (benign mermaid version warning only)aggregate.yml)Follow-ups (out of scope for this rename)
mdbook-linkcheckgate. The QA sweep noted broken relative links pass CI silently. Adding a linkcheck backend todocs/book.toml(or alycheeCI step) is a separate change — flagging as a follow-up, not done here.CONTRIBUTING.md:18anddocs/sync-architecture.md:36still say CI pins mdBookv0.4.40, butaggregate.ymlinstalls 0.5.2. Nodeploy.ymltoken involved; left untouched to keep this PR scoped.🤖 Generated with Claude Code
https://claude.ai/code/session_01R7vqjjo5nrebYNt8WnCNbz