Skip to content

[AAASM-4135] 📝 (docs): Fix off-project SCIM domain to agent-assembly.com#52

Merged
Chisanan232 merged 1 commit into
mainfrom
v0.0.1/AAASM-4135/fix_agentassembly_io_domain
Jul 5, 2026
Merged

[AAASM-4135] 📝 (docs): Fix off-project SCIM domain to agent-assembly.com#52
Chisanan232 merged 1 commit into
mainfrom
v0.0.1/AAASM-4135/fix_agentassembly_io_domain

Conversation

@Chisanan232

Copy link
Copy Markdown
Contributor

Description

docs/src/cloud-deployment.md used https://api.agentassembly.io/scim/v2 as the illustrative SCIM Endpoint URL — wrong TLD (.io) and missing the hyphen versus the canonical agent-assembly.com used 12× elsewhere in the docs. agentassembly.io resolves to a third-party IP, so the value pointed off-project. It has no live hyperlink but slipped past the earlier docs domain-TLD fix (AAASM-4101 / PR #51). Corrected to https://api.agent-assembly.com/scim/v2. A repo-wide grep confirms this was the only stale off-project agentassembly/.io literal.

Type of Change

  • 🐛 Bug fix (correcting inaccurate or missing content)

Related Issues

  • Related Jira ticket: AAASM-4135
  • Related GitHub issues: N/A

Documentation Checklist

  • cd docs && mdbook build passes locally with no warnings
  • All internal cross-links verified
  • Page registered in docs/src/SUMMARY.md
  • Self-hosted instructions not included (SaaS-only scope)
  • "Last reviewed" footer updated with today's date
  • Commits follow GitEmoji convention and are small / atomic

🤖 Generated with Claude Code

https://claude.ai/code/session_01R7vqjjo5nrebYNt8WnCNbz

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01R7vqjjo5nrebYNt8WnCNbz
@sonarqubecloud

sonarqubecloud Bot commented Jul 4, 2026

Copy link
Copy Markdown

@Chisanan232

Copy link
Copy Markdown
Contributor Author

Claude Code review — APPROVE (comment-only, not a formal approval)

Reviewed against AAASM-4135 across 4 dimensions.

1. CI — Green: Aggregate all module docs pass, SonarCloud Code Analysis pass, Deploy to GitHub Pages skipping (expected on a PR event, not a failure). mdbook build runs clean locally (only an unrelated mdbook-mermaid version-mismatch warning, pre-existing).

2. Scope vs ticket — Matches exactly. AAASM-4135 (LOW, off-project domain) targets the single illustrative SCIM Endpoint URL in docs/src/cloud-deployment.md that used the wrong-TLD/no-hyphen api.agentassembly.io. Fixed to https://api.agent-assembly.com/scim/v2 (line 132). A repo-wide git grep -E 'agentassembly|agent-assembly\.io' over tracked files returns nothing — this was the only stale off-project literal. (HTML hits under docs/book/ are untracked build output, regenerated on build.)

3. Side effects — Diff is exactly 1 file / 1 line, content-only. No cross-links broken; mdbook build succeeds and the page still renders. No other files touched.

4. FE — N/A.

Local checks passed (grep clean on tracked source, mdbook build succeeds). LGTM.

— Claude Code

@Chisanan232 Chisanan232 merged commit bec728a into main Jul 5, 2026
3 checks passed
@Chisanan232 Chisanan232 deleted the v0.0.1/AAASM-4135/fix_agentassembly_io_domain branch July 5, 2026 00:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant