added support for generating waveform in time domain. This modificati…#13
Merged
ahnitz merged 5 commits intoahnitz:firinspiral2from Mar 16, 2026
Merged
Conversation
…on works for any seed bank generated using time domain waveform model
Owner
|
@Kanchan-05 This appears to be duplicating some lines above now. Shouldn't you just be changing the if statement logic a few lines above rather than adding new lines? |
ahnitz
approved these changes
Mar 16, 2026
ahnitz
added a commit
that referenced
this pull request
Mar 16, 2026
added support for generating waveform in time domain. This modificati…
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request adds support for generating waveforms in the time domain while generating polarizations in pycbc_brute_bank.
Standard information about the request
This is a: bug fix, new feature, efficiency update, other (please describe)
This change affects: the offline search, the live search, inference, PyGRB
This change changes: documentation, result presentation / plotting, scientific output
This change: has appropriate unit tests, follows style guidelines (See e.g. PEP8), has been proposed using the contribution guidelines
This change will: break current functionality, require additional dependencies, require a new release, other (please describe)
Motivation
Contents
Links to any issues or associated PRs
Testing performed
Additional notes