minimal changes to compile a 2.13.x compatible version#1
Open
ahepburn-sumologic wants to merge 9 commits intomaintenance-v1.1from
Open
minimal changes to compile a 2.13.x compatible version#1ahepburn-sumologic wants to merge 9 commits intomaintenance-v1.1from
ahepburn-sumologic wants to merge 9 commits intomaintenance-v1.1from
Conversation
33ca43a to
452faed
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
note - this requires java8 to build locally due to sun.misc.unsafe usage (unchanged in later kamon)
Kamon 2.*(the first version stably cross-compiled for Scala 2.13) has significant changes, whereas the changes to compile 1.1.x are actually minimalkamon-core