Fix EMR and Glue operator on_kill to check terminal state before cancellation#1
Open
Fix EMR and Glue operator on_kill to check terminal state before cancellation#1
Conversation
Co-authored-by: agupta01 <12228572+agupta01@users.noreply.github.com>
Co-authored-by: agupta01 <12228572+agupta01@users.noreply.github.com>
Co-authored-by: agupta01 <12228572+agupta01@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix job cancellation command for terminal states
Fix EMR and Glue operator on_kill to check terminal state before cancellation
Dec 4, 2025
agupta01
approved these changes
Dec 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
on_killmethods in EMR and Glue operators attempted to cancel jobs regardless of their current state, causing unnecessary API calls and potential errors when jobs were already complete.Changes
Operator modifications:
EmrServerlessStartJobOperator: Check job state viaget_job_run()before callingcancel_job_run()EmrContainerOperator: Check job state viacheck_query_status()before callingstop_query()GlueJobOperator: Check job state viaget_job_state()before callingbatch_stop_job_run()EmrCreateJobFlowOperator: Check cluster state viadescribe_cluster()before callingterminate_job_flows()Hook improvements:
JOB_TERMINAL_STATEStoGlueJobHook(["FAILED", "TIMEOUT", "SUCCEEDED", "STOPPED"])CLUSTER_TERMINAL_STATEStoEmrHook(["TERMINATED", "TERMINATED_WITH_ERRORS"])GlueJobHook._handle_state()to use class constantsAll state checks include try-except fallback to preserve existing behavior if state retrieval fails.
Example
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.Original prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.