Open
Conversation
…ate in "l/ha" refers to spraying solution as before in [srppp::use-rates] In the current comit `rate` is only assumed to be spraying solution if above 100 l/ha and as before unit == "l/ha" & is.na(g_perL) & !is.na(dosage). The threshold rate of 100 l/ha was set because there exist some entries where the rate is low and likely refers to the product rate (e.g. Arbo 2016 with active ingedient "Bacillus thuringiensis var. kurstaki" and rate 1 l/ha).
In _pkgdown.yml, 1 topic missing from index: "product_rates". Either add to the reference index, or use `@keywords internal` to drop from the index.
The test in this Pull Request was outdated, the warnings therein were already fixed in main and on this branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current function
application_rate_g_per_ha()calculates application rates for active ingredients.Add new function
product_rates()which calculates product application rates in kg/ha or l/ha (prod_unit column).The function
application_rate_g_per_ha()now usesproduct_rates()as a basis to calculate application rates for active ingredients.