Support self referential tables for SQLModels#467
Merged
sheinbergon merged 5 commits intoagronholm:masterfrom Feb 27, 2026
Merged
Support self referential tables for SQLModels#467sheinbergon merged 5 commits intoagronholm:masterfrom
sheinbergon merged 5 commits intoagronholm:masterfrom
Conversation
Collaborator
Author
|
@agronholm coveralls is currently down, but tests are passing locally. It's ready for review |
Owner
|
I'll review this tomorrow. |
agronholm
reviewed
Feb 26, 2026
agronholm
reviewed
Feb 26, 2026
agronholm
reviewed
Feb 26, 2026
Co-authored-by: Alex Grönholm <alex.gronholm@nextday.fi>
Co-authored-by: Alex Grönholm <alex.gronholm@nextday.fi>
agronholm
reviewed
Feb 26, 2026
Collaborator
Author
|
@StrikerRUS can you confirm the code on my branch addresses the errors you've encountered? |
|
@sheinbergon Thanks a lot for the PR! Will check this weekend. |
StrikerRUS
approved these changes
Feb 27, 2026
StrikerRUS
left a comment
There was a problem hiding this comment.
@sheinbergon
Just checked your branch - my initial example now works fine without errors. Thank you so much for prompt fix!
Collaborator
Author
|
@agronholm coveralls is still down (what a blunder), but test are passing locally. I'll take the liberty of merging this PR. |
Owner
|
The issue with the Coveralls site isn't even technical – it's an account issue with their infrastructure provider. |
|
Thanks for the fix! |
Collaborator
Author
Ein ba'ad ma |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Add support for self-referential tables for SQLModels
For a tabe definition like
The generated output changes from:
to:
Fixes #460
Checklist
If this is a user-facing code change, like a bugfix or a new feature, please ensure that
you've fulfilled the following conditions (where applicable):
tests/) which would fail without your patchCHANGES.rst).