You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This fixes the missing metadata argument when rendering a plain Table with the SQLModel generator.
It contains a hack that replaces self.base.metadata_ref which is otherwise overridden by the declarative generator during generate_models().
If this is a user-facing code change, like a bugfix or a new feature, please ensure that
you've fulfilled the following conditions (where applicable):
You've added tests (in tests/) which would fail without your patch
You've added a new changelog entry (in CHANGES.rst).
If this is a trivial change, like a typo fix or a code reformatting, then you can ignore
these instructions.
Updating the changelog
If there are no entries after the last release, use **UNRELEASED** as the version.
If, say, your patch fixes issue #123, the entry should look like this:
- Fix big bad boo-boo in task groups
(`#123 <https://github.com/agronholm/sqlacodegen/issues/123>`_; PR by @yourgithubaccount)
If there's no issue linked, just link to your pull request instead by updating the
changelog after you've created the PR.
This fixes the missing metadata argument when rendering a plain Table with the SQLModel generator. It contains a hack that replaces self.base.metadata_ref which is otherwise overridden by the declarative generator during generate_models().
You can probably juat extract the metadata_ref in the base class instead of overriding and calling the super, which would also make things less hacky.
This fixes the missing metadata argument when rendering a plain Table with the SQLModel generator. It contains a hack that replaces self.base.metadata_ref which is otherwise overridden by the declarative generator during generate_models().
You can probably juat extract the metadata_ref in the base class instead of overriding and calling the super, which would also make things less hacky.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
This fixes the missing metadata argument when rendering a plain
Tablewith the SQLModel generator.It contains a hack that replaces
self.base.metadata_refwhich is otherwise overridden by the declarative generator duringgenerate_models().Fixes #465.
Checklist
If this is a user-facing code change, like a bugfix or a new feature, please ensure that
you've fulfilled the following conditions (where applicable):
tests/) which would fail without your patchCHANGES.rst).If this is a trivial change, like a typo fix or a code reformatting, then you can ignore
these instructions.
Updating the changelog
If there are no entries after the last release, use
**UNRELEASED**as the version.If, say, your patch fixes issue #123, the entry should look like this:
If there's no issue linked, just link to your pull request instead by updating the
changelog after you've created the PR.