Fix inherited kwargs rendering for MySQL CHAR collation#464
Merged
sheinbergon merged 3 commits intoagronholm:masterfrom Feb 23, 2026
Merged
Fix inherited kwargs rendering for MySQL CHAR collation#464sheinbergon merged 3 commits intoagronholm:masterfrom
sheinbergon merged 3 commits intoagronholm:masterfrom
Conversation
sheinbergon
reviewed
Feb 20, 2026
Collaborator
sheinbergon
left a comment
There was a problem hiding this comment.
Thank you very much for your contribution. Left some cosmetric comments. Don't forget updating CHANGES.rst
Collaborator
|
@hyoj0942 also notice pre-commit is failing. Be sure to fix linting/formatting/typing issues |
- extract helper methods from render_column_type() for readability\n- split inherited init kwargs collection into a dedicated helper\n- add CHANGES.rst Unreleased entry for agronholm#285 fix\n- ensure pre-commit hooks pass
Contributor
Author
|
@sheinbergon heads-up: I fixed the pre-commit issues and pushed an update ( |
Added contributor information for a fix regarding inherited keyword arguments in dialect-specific types.
sheinbergon
approved these changes
Feb 23, 2026
Collaborator
Great. Will be released as part of the next patch version |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
**kwargsCHAR(..., collation=...)when usingkeep_dialect_typesSET)Tests
PYTHONPATH=src pytest -q tests/test_generator_tables.py -k 'mysql'PYTHONPATH=src pytest -q tests/test_generator_declarative.py -k 'keep_dialect_types'Closes #285.