Open
Conversation
…ven/bincaml into wrapping-intervals
agle
reviewed
Feb 4, 2026
Owner
agle
left a comment
agle
left a comment
There was a problem hiding this comment.
Good work,
If you want to fix the typecheck tests you can change dune exec bincaml to ../../bin/main.exe in typefail.t and typepass.t
| type l = Top | Interval of { lower : Bitvec.t; upper : Bitvec.t } | Bot | ||
| [@@deriving eq] | ||
|
|
||
| type t = { w : int option; v : l } |
Owner
There was a problem hiding this comment.
Not for this PR, but this is functionally two domains I think, a width inference domain wrapping the circular interval domain, and they could be separated which would clean up the code here. It may be enough to just always pass type information to the analysis functions but I'll have a look at that refactor when I get time
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Interval analysis, but on a circle!