Skip to content

feat: improve message formatting in NewCodeErrWithMsg function#2

Merged
kooksee merged 2 commits into
aginetwork7:masterfrom
fmyAgi7:fix/NewCodeErrWithMsg
Jan 19, 2026
Merged

feat: improve message formatting in NewCodeErrWithMsg function#2
kooksee merged 2 commits into
aginetwork7:masterfrom
fmyAgi7:fix/NewCodeErrWithMsg

Conversation

@fmyAgi7

@fmyAgi7 fmyAgi7 commented Jan 19, 2026

Copy link
Copy Markdown

No description provided.

@gemini-code-assist

Copy link
Copy Markdown

Summary of Changes

Hello @fmyAgi7, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request refines the error message formatting within the NewCodeErrWithMsg function by adopting the golang.org/x/text/cases package for title casing. This change ensures that error messages are capitalized more accurately and consistently. A corresponding test has been added to validate the new formatting behavior.

Highlights

  • Improved Error Message Formatting: The NewCodeErrWithMsg function now uses golang.org/x/text/cases for title casing error messages, replacing the simpler strings.ToTitle. This provides more robust and linguistically accurate capitalization.
  • New Imports: The errors/err_code.go file now imports golang.org/x/text/cases and golang.org/x/text/language to support the enhanced message formatting.
  • New Test Case: A new test, TestNewCodeErrWithMsg, has been added to errors/z_err_code_test.go to verify that the NewCodeErrWithMsg function correctly applies title casing to error messages (e.g., 'hello world' becomes 'Hello World').

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request correctly replaces the deprecated strings.ToTitle with the recommended golang.org/x/text/cases package for title-casing error messages. However, I've identified a performance issue in the implementation where a cases.Caser is created on each call, which should be a package-level singleton. Additionally, the new test has a critical flaw where it can panic due to a nil pointer dereference. My comments provide details and suggestions for fixing these issues.

Comment thread errors/z_err_code_test.go Outdated
Comment thread errors/err_code.go Outdated
@kooksee kooksee merged commit 376b0fb into aginetwork7:master Jan 19, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants