Skip to content

chore: fix build script to always run from repo root #299

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mdqst wants to merge 1 commit into
base: main
Choose a base branch
from
Open

chore: fix build script to always run from repo root #299

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions scripts/build-docker-images
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,6 @@
#!/bin/sh
#!/bin/bash

echo "Building the docker images. Note this script should be run from the repository root."
docker build -t aggkit-prover:local .
SCRIPT_DIR="$(cd "$(dirname "$0")" && pwd)"
Copy link
Contributor

@iljakuklic iljakuklic Nov 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm wondering if something like the following would be enough:

SCRIPT_DIR="$(dirname "$0")"

It might treat symlinks a bit differently but is it an issue?

Also, the echo message saying the script should run from the root will be outdated with this change.

REPO_ROOT="$SCRIPT_DIR/.."
docker build -t aggkit-prover:local "$REPO_ROOT"