feat: require OP hardfork keys in evm-sketch-genesis
#241
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hadjiszs
commented
Jun 17, 2025
Ekleog-Polygon
previously approved these changes
Jun 17, 2025
Freyskeyd
previously approved these changes
Jun 17, 2025
hadjiszs
changed the title
evm-sketch-genesis
iljakuklic
approved these changes
Jun 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update
evm-sketch-genesisparsing to use OP configuration keysTriggered by an upgrade to
sp1-contract-call, which now expects OP-stylegenesis fields when parsing chain configuration.
The
evm-sketch-genesisconfig under[aggchain-proof-service.aggchain-proof-builder.contracts]previouslyused Ethereum L1 hardfork keys (e.g.,
pragueTime). It must now includeOP Stack keys like
isthmusTimeandcanyonTime.Ethereum fields can still be present, but OP keys are now required.
CONFIG-CHANGE:
evm-sketch-genesisnow expects OP hardfork namesThe genesis JSON must include OP hardfork keys (e.g.,
isthmusTime).Including both Ethereum and OP fields is allowed, but OP keys are required.