Draft
Conversation
sebastiendan
force-pushed
the
feat-rework-charts-argocd
branch
from
ddbd52b to
c168f57
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
This PR reworks several Helm charts to better support ArgoCD workflows by standardizing metadata/labels, introducing 1Password Operator integration, enabling config env-substitution via initContainers, and adding Gateway API HTTPRoute + GKE HealthCheckPolicy options.
Changes:
- Add
metadata(env/costCenter) labeling and standardize values structure across charts. - Introduce
onePasswordSecrets+ templatedOnePasswordItemCRs and optional env-substitution initContainers (envsubst). - Add/adjust HTTP exposure via
HTTPRoute+HealthCheckPolicy, and update config/volume layouts and chart versions.
Reviewed changes
Copilot reviewed 33 out of 33 changed files in this pull request and generated 13 comments.
Show a summary per file
| File | Description |
|---|---|
| charts/pool-manager/values.yaml | Restructures values (metadata, 1Password secrets, env-substitution, probes) and updates image/config paths. |
| charts/pool-manager/templates/onepassworditem.yaml | Generates OnePasswordItem resources from onePasswordSecrets. |
| charts/pool-manager/templates/deployment.yaml | Adds env-substitution initContainer and reworks config volumes/mounts. |
| charts/pool-manager/templates/configmap.yaml | Renames config key to config.toml and sources DB config from values. |
| charts/pool-manager/templates/_helpers.tpl | Adds cost-center label (but still references old env value path). |
| charts/pool-manager/Chart.yaml | Bumps chart version to 1.0.0. |
| charts/cdk-erigon/values.yaml | Restructures values (metadata, env-substitution, routes, probes) and rewrites config structure. |
| charts/cdk-erigon/templates/statefulset.yaml | Uses new values keys, adds env-substitution initContainer, extra containers/volumes, probes, and storage rename. |
| charts/cdk-erigon/templates/onepassworditem.yaml | Generates OnePasswordItem resources from onePasswordSecrets. |
| charts/cdk-erigon/templates/ingress.yaml | Scopes ingress to ingress.rpc.* and adjusts naming/annotations. |
| charts/cdk-erigon/templates/httproute.yaml | Adds optional Gateway API HTTPRoute for RPC exposure. |
| charts/cdk-erigon/templates/healthcheckpolicy.yaml | Adds optional GKE HealthCheckPolicy when using HTTPRoute. |
| charts/cdk-erigon/templates/configmap.yaml | Replaces prior secret-driven config with values-driven erigon.yaml + dynamic JSONs. |
| charts/cdk-erigon/templates/_helpers.tpl | Switches env tag to metadata.env and adds cost-center label. |
| charts/cdk-erigon/Chart.yaml | Bumps chart version to 1.0.0. |
| charts/bridge/values.yaml | Restructures values (metadata, env-substitution, routes, probes) and updates config fields. |
| charts/bridge/templates/service.yaml | Removes BackendConfig annotation/resource from service template. |
| charts/bridge/templates/onepassworditem.yaml | Generates OnePasswordItem resources from onePasswordSecrets. |
| charts/bridge/templates/ingress.yaml | Makes ingress creation conditional and closes template with end. |
| charts/bridge/templates/httproute.yaml | Adds optional Gateway API HTTPRoute for REST exposure. |
| charts/bridge/templates/healthcheckpolicy.yaml | Adds optional GKE HealthCheckPolicy when using HTTPRoute. |
| charts/bridge/templates/deployment.yaml | Adds env-substitution initContainer, config/keystore volume changes, probes wiring. |
| charts/bridge/templates/configmap.yaml | Removes runtime secret lookups and builds TOML config from values (incl. KMS vs file key selection). |
| charts/bridge/templates/_helpers.tpl | Switches env tag to metadata.env and adds cost-center label. |
| charts/bridge/Chart.yaml | Bumps chart version to 2.0.0. |
| charts/bridge-tester/templates/cronjob.yaml | Improves Datadog JSON logging (proper escaping + richer failure summary). |
| charts/bridge-tester/Chart.yaml | Bumps chart version to 2.1.0. |
| charts/aggkit/values.yaml | Restructures values (metadata, env-substitution, routes) and updates several config field names/defaults. |
| charts/aggkit/templates/statefulset.yaml | Adds env-substitution initContainer and config/keystore volume layout changes. |
| charts/aggkit/templates/httproute.yaml | Adds HTTPRoutes for additional ports and a HealthCheckPolicy for Gateway exposure. |
| charts/aggkit/templates/configmap.yaml | Switches to values-driven RPC URLs and keystore password fields, and adds document separator. |
| charts/aggkit/templates/_helpers.tpl | Switches env tag to metadata.env and adds cost-center label. |
| charts/aggkit/Chart.yaml | Bumps chart version to 7.0.0. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
sebastiendan
force-pushed
the
feat-rework-charts-argocd
branch
from
9e6c400 to
d9376f9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.