fix(mcp-proxy): record pre-approval deny evidence#47
Merged
Conversation
Persist terminal blocked evidence for unknown-tool and schema-deny paths before approval while keeping the deny responses unchanged. Add product-path regression coverage for evidence count, terminal deny reason, and raw-argument privacy. Implemented with assistance from Codex.
e1547f9 to
ad1577b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Scope
Product-Path Acceptance
codex/mcp-proxy-preapproval-deny-evidence, commitad1577b, baseaabc009Type-specific gate:
Validation
PYTHONPATH=../..:. python3 -m pytest tests/test_mcp_proxy_passthrough.py::test_unknown_tool_hard_deny_writes_terminal_blocked_evidence tests/test_mcp_proxy_passthrough.py::test_schema_deny_writes_terminal_blocked_evidence -q-> 2 passedPYTHONPATH=../..:. python3 -m pytest tests/test_mcp_proxy_passthrough.py tests/test_mcp_proxy_tool_surface.py tests/test_mcp_proxy_evidence.py tests/test_mcp_proxy_passthrough_concurrent.py -q-> 142 passed, 1 skippedaabc009:PYTHONPATH=../..:. python3 -m pytest tests/test_mcp_proxy_passthrough.py::test_unknown_tool_hard_deny_writes_terminal_blocked_evidence tests/test_mcp_proxy_passthrough.py::test_schema_deny_writes_terminal_blocked_evidence -q-> 2 passedgit diff --check/git diff --cached --check-> passedRelease / Claim Notes
Implemented with assistance from Codex.