fix(mcp-proxy): honor approval timeout across poll slices#46
Merged
Conversation
Keep nonblocking approval watchers alive until the configured approval timeout expires so a slow local approval can be reused by the retry path instead of creating a new pending prompt. Add product-path regression coverage for approval -> retry -> downstream execution without a second pending approval. Implemented with assistance from Codex.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Scope
Product-Path Acceptance
codex/mcp-proxy-approval-retry-loop, commite36cc5a, base4ccc8ecapproved; child retry record reachesexecuted; no raw file content/secrets asserted in the focused acceptance path.Type-specific gate:
Validation
PYTHONPATH=../..:. python3 -m pytest tests/test_mcp_proxy_approval.py::test_nonblocking_watcher_honors_full_timeout_before_expiring tests/test_mcp_proxy_approval.py::test_nonblocking_retry_after_approval_executes_downstream tests/test_mcp_proxy_runtime_gate.py::test_waiting_retry_after_local_approval_executes_downstream -q-> 3 passedPYTHONPATH=../..:. python3 -m pytest tests/test_mcp_proxy_approval.py tests/test_mcp_proxy_runtime_gate.py tests/test_mcp_proxy_evidence.py -q-> 163 passedPYTHONPATH=../..:. python3 -m pytest tests/test_mcp_proxy_passthrough.py tests/test_mcp_proxy_passthrough_concurrent.py -q-> 68 passed, 1 skippedgit diff --check/git diff --cached --check-> passedRelease / Claim Notes
Implemented with assistance from Codex.