Protect #139
Open
Protect #139
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cking just to the one used for access control.
…ndle an entity is part of for access control.
Per suggestion by @biz123
| * TRUE if content is assigned to this entity. | ||
| * FALSE if content is not assigned to this entity. | ||
| */ | ||
| private function hasContent(EntityInterface $entity) { |
There was a problem hiding this comment.
add a call to a method here that will check to see if the term has children or not.
TODO: figure out how to abstract this so that this class doesn't have any explicit taxonomy or term references. Adding a method to the Drupal\workbench_access\Plugin\AccessControlHierarchy class to see if this scheme has children might be the way to do it.
…ch access configuration, which knows where to look.
|
Here's a patch that resolves everything flagged by the client's coding style checks. (gzipped because GitHub doesn't support an upload of |
|
@agentrickard I created #143 for some additional changes flagged by PHPMD. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new branch of @jasonpartyka's workbench access protect addition.