Skip to content

fix: align promptfoo adapter variables#21

Merged
aryeko merged 1 commit into
mainfrom
fix/promptfoo-vars
Jul 3, 2026
Merged

fix: align promptfoo adapter variables#21
aryeko merged 1 commit into
mainfrom
fix/promptfoo-vars

Conversation

@aryeko

@aryeko aryeko commented Jul 3, 2026

Copy link
Copy Markdown
Contributor

Summary

  • return the generic shared eval-kit prompt variables from technical-design generation, pointwise, and pairwise adapter hooks
  • preserve technical-design semantics inside source material, candidate instructions, rubrics, and expected item values
  • add adapter hook tests that assert the bundled prompt variable contract
  • keep @agentic-workflow-kit/eval-kit pinned to the existing Git tag; no local package is reintroduced

Verification

  • pnpm eval:unit -- evals/tests/public-reference-cases.test.mjs (red before the adapter fix; green after)
  • pnpm format
  • pnpm install --frozen-lockfile
  • pnpm check
  • pnpm eval:case -- --case case-tiny-laundry-pickup-v1 --candidate evals/cases/case-tiny-laundry-pickup-v1/reference-design.md --run-id verify-shared-eval-kit
  • git diff --check

Optional model-assisted smoke

  • codex login status reports ChatGPT auth
  • pnpm eval:generate produced a Promptfoo config with the generic variables, but the external model smoke was not completed because retrying the provider call was blocked by policy as an external transfer of repository prompt content
  • pnpm eval:judge:coverage was not run for the same reason

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 777f3995ee

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread evals/adapter.mjs
@aryeko aryeko merged commit de9efc9 into main Jul 3, 2026
1 check passed
@aryeko aryeko deleted the fix/promptfoo-vars branch July 3, 2026 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant