Skip to content

Clarify verification lane product and design boundaries#82

Merged
aryeko merged 3 commits into
mainfrom
docs/product-verification-lane
Jul 7, 2026
Merged

Clarify verification lane product and design boundaries#82
aryeko merged 3 commits into
mainfrom
docs/product-verification-lane

Conversation

@aryeko

@aryeko aryeko commented Jul 6, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Clarifies product docs: verification before landing is a configurable acceptance/review lane.
  • Clarifies boundaries: Worker implements, Verifier reviews, Runner orchestrates/enforces, Forge performs deterministic external operations.
  • Aligns design docs with the product model.
  • Leaves implementation/runtime changes for a follow-up PR.

Non-goals

  • No runtime implementation.
  • No schema changes.
  • No provider interface changes.
  • No SEC-2 enforced-egress implementation.
  • No change to Forge/Worker credentials behavior.

Product acceptance

  • PROD-AC-1 clear product promise
  • PROD-AC-2 entity model explicit
  • PROD-AC-3 Runner boundary explicit
  • PROD-AC-4 Worker boundary explicit
  • PROD-AC-5 acceptance/review lane first-class
  • PROD-AC-6 reviewer/verifier boundary explicit
  • PROD-AC-7 Forge provider deterministic capability
  • PROD-AC-8 existing guarantees stay honest
  • PROD-AC-9 no implementation promise sneaks in
  • PROD-AC-10 product altitude preserved

Design acceptance

  • DES-AC-1 reflects product change only
  • DES-AC-2 Runner remains orchestrator
  • DES-AC-3 Verifier/reviewer is governed lane
  • DES-AC-4 policy/config own acceptance strength
  • DES-AC-5 Forge provider remains deterministic
  • DES-AC-6 Worker remains implementation-only
  • DES-AC-7 Fence/Doorbell integration coherent
  • DES-AC-8 records/evidence model durable
  • DES-AC-9 SEC-2/provider seams not muddied
  • DES-AC-10 no implementation changes

Independent reviews

Product-doc review

Final verdict: pass.

Blocking findings: none.

Non-blocking suggestions: none.

Reviewer confirmation: product docs satisfy PROD-AC-1 through PROD-AC-10; the docs do not claim implementation that does not exist; Runner/Worker/Verifier/Forge boundaries are clear; existing product guarantees are not weakened; product docs stay at product altitude; no cross-repo suite boundary is violated; no stale links/headings/navigation were introduced.

Design-doc review

Final verdict: pass.

Blocking findings: none.

Non-blocking suggestions: none.

Reviewer confirmation: design docs satisfy DES-AC-1 through DES-AC-10; they follow the product docs without inventing new product facts; Runner/Worker/Verifier/Forge/Fence/Doorbell boundaries are internally consistent; acceptance/review lane is policy/config-owned and launch-bound; Forge provider is deterministic adapter capability, not another agent; SEC-2 execution-host confinement remains separate from review/acceptance; no implementation behavior is claimed as shipped unless already true; links/headings/navigation remain valid.

Verification

  • git status --short --branch before branch creation: ## main...origin/main with no changes.
  • git worktree list: confirmed /Users/aryekogan/repos/agentic-workflow-kit/jig on main before creating the feature worktree.
  • pnpm install --frozen-lockfile before edits: passed. Output included Scope: all 5 workspace projects, Lockfile is up to date, resolution step is skipped, Already up to date, Done in 371ms using pnpm v11.9.0.
  • pnpm check before edits: passed. Ran lint, format, typecheck, package boundaries, doc links, delivery foundation, and tests. Result: Doc link check passed (206 Markdown files scanned), 55 passed | 5 skipped (60) test files, 673 passed | 7 skipped (680) tests, coverage statements 96.57%.
  • pnpm exec prettier --write docs/product/jig.md docs/product/guarantees.md docs/product/concepts.md docs/product/README.md: passed.
  • pnpm links:check after product-doc edits: passed. Output: Doc link check passed (206 Markdown files scanned).
  • git diff --check -- docs/product: passed with no output.
  • Independent product-doc review: pass after fixing one initial overclaim about implemented acceptance/review behavior.
  • pnpm exec prettier --write docs/design/README.md docs/design/core/README.md docs/design/core/orchestration.md docs/design/core/authorization.md docs/design/core/plan-intake.md docs/design/core/records.md docs/design/core/bootstrap.md docs/design/contracts/providers.md docs/design/security-model.md: passed.
  • pnpm links:check after design-doc edits: passed. Output: Doc link check passed (206 Markdown files scanned).
  • git diff --check: passed with no output.
  • Independent design-doc review: pass; a non-blocking diagram suggestion was addressed, then the reviewer returned pass with no suggestions.
  • pnpm install --frozen-lockfile final: passed with exit code 0. Output included Scope: all 5 workspace projects, Already up to date, Done in 214ms using pnpm v11.9.0; pnpm also printed a non-fatal update-check warning: [ERR_PNPM_META_FETCH_FAIL] GET https://registry.npmjs.org/pnpm: fetch failed.
  • pnpm check final: passed. Ran lint, format, typecheck, package boundaries, doc links, delivery foundation, and tests. Result: Checked 148 files, All matched files use Prettier code style!, Doc link check passed (206 Markdown files scanned), Delivery foundation fixture conventions are present, Phase-table and phase-doc frontmatter statuses agree, 55 passed | 5 skipped (60) test files, 673 passed | 7 skipped (680) tests, coverage statements 96.57%, branches 91.08%, functions 96.66%, lines 96.61%.
  • git status --short --branch final before push: clean on docs/product-verification-lane.

Implementation follow-up intentionally left to a later PR: model the acceptance/review lane in runtime/config/policy, add records/verdict handling if needed, and wire enforcement before Forge landing.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: ef19dfb108

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread docs/product/jig.md Outdated
@aryeko aryeko merged commit e510ed7 into main Jul 7, 2026
1 check passed
@aryeko aryeko deleted the docs/product-verification-lane branch July 7, 2026 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant