Skip to content

fix: ignore bootstrapped eval result bundles#15

Merged
aryeko merged 1 commit into
mainfrom
fix/bootstrap-results-ignore-v017
Jul 4, 2026
Merged

fix: ignore bootstrapped eval result bundles#15
aryeko merged 1 commit into
mainfrom
fix/bootstrap-results-ignore-v017

Conversation

@aryeko

@aryeko aryeko commented Jul 4, 2026

Copy link
Copy Markdown
Contributor

Summary

  • generate evals/results/.gitignore during generic bootstrap
  • keep raw result bundles local by default while preserving README and the ignore file
  • update bootstrap tests for dry-run and generated skeleton behavior

Verification

  • pnpm install --frozen-lockfile
  • pnpm test -- tests/bootstrap-cli.test.mjs
  • pnpm format
  • pnpm check
  • git diff --check
  • targeted result-ignore guidance sweep

Independent pre-PR review

  • reviewer verdict: approve
  • findings: no P0/P1 findings

@aryeko aryeko merged commit 1b986b5 into main Jul 4, 2026
1 check passed
@aryeko aryeko deleted the fix/bootstrap-results-ignore-v017 branch July 4, 2026 02:47

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 78a3b03596

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread src/bootstrap.mjs
relativePath: "evals/results/.gitignore",
content: [
"# Keep raw eval result bundles local unless a human curates a summary.",
"*",

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Allow curated result summaries to be added normally

When a consumer creates a curated summary under evals/results/, this * rule ignores every new file except the two explicit exceptions, so git status hides something like evals/results/summary.md and plain git add evals/results/summary.md is rejected unless the user knows to force-add or edit the ignore file. I verified this with git check-ignore -v, and Git's gitignore docs describe ! as only re-including matching exception paths; this contradicts the generated README/docs policy that humans can commit curated summaries while only raw run bundles stay local.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant