feat: add semantic PRD eval suite#8
Merged
Merged
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: e8b2f76fc8
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds the Phase 3 deterministic semantic eval suite for define-product. The suite covers PRD contract completeness, stable AC-ID behavior during revision, insufficient-input blocking behavior, product-altitude boundaries, current/future scope separation, source-grounded uncertainty, and downstream citeability.
Also updates
@agentic-workflow-kit/eval-kittogithub:agentic-workflow-kit/eval-kit#v0.1.2so disabled model-assisted commands fail closed in this consumer.Eval Fixture Behavior
pnpm eval:validate-fixturesto fail closed: it validates the expected-check schema, proves malformed check probes throw, requires good fixtures to grade green, and requires bad fixtures to grade red.Verification
pnpm install --frozen-lockfilepnpm eval:doctorpnpm eval:listpnpm eval:validate-fixturespnpm checkgit diff --checkcase-contract-grounded-prd-v1withcandidate-good.mdexited 0, verdict green.case-contract-grounded-prd-v1withcandidate-bad.mdexited 1, verdict red.text_includesexpectations and missingac_ids_present.idsboth fail closed.