refactor(models): Refine MessageAgentThought SQLAlchemy typing#11
Conversation
| tool_call_response.append( | ||
| ToolPromptMessage( | ||
| content=tool_responses.get(tool, agent_thought.observation), | ||
| content=str(tool_inputs.get(tool, agent_thought.observation)), |
There was a problem hiding this comment.
Bug: The organize_agent_history method incorrectly uses tool_inputs instead of tool_responses for the content of a ToolPromptMessage, breaking the agent's reasoning.
Severity: CRITICAL
Suggested Fix
In api/core/agent/base_agent_runner.py on line 502, change content=str(tool_inputs.get(tool, agent_thought.observation)) to content=str(tool_responses.get(tool, agent_thought.observation)) to correctly use the tool's response content.
Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent.
Verify if this is a real issue. If it is, propose a fix; if not, explain why it's not
valid.
Location: api/core/agent/base_agent_runner.py#L502
Potential issue: In the `organize_agent_history` method, when constructing the
conversation history, the content for the `ToolPromptMessage` is incorrectly sourced
from the `tool_inputs` dictionary instead of the `tool_responses` dictionary. This
causes the agent to receive its own tool call inputs as if they were the tool's output.
This breaks the logical flow of the conversation history, as the
`AssistantPromptMessage` contains the tool call inputs, and the subsequent
`ToolPromptMessage` should contain the corresponding responses. This will prevent the
agent from correctly reasoning about the results of its tool executions.
Did we get this right? 👍 / 👎 to inform future reviews.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Benchmark PR from agentic-review-benchmarks#11