feat: get plan bulk with cache#10
Open
tomerqodo wants to merge 4 commits intosentry_full_base_feat_get_plan_bulk_with_cache_pr10from
Open
feat: get plan bulk with cache#10tomerqodo wants to merge 4 commits intosentry_full_base_feat_get_plan_bulk_with_cache_pr10from
tomerqodo wants to merge 4 commits intosentry_full_base_feat_get_plan_bulk_with_cache_pr10from
Conversation
Comment on lines
+365
to
+367
| for tenant_id, subscription_plan in bulk_plans.items(): | ||
| tenant_plans[tenant_id] = subscription_plan | ||
| plans_to_cache[tenant_id] = subscription_plan |
There was a problem hiding this comment.
Bug: The function get_plan_bulk_with_cache caches None values for invalid plans, causing subsequent cache reads to fail validation and trigger unnecessary API calls.
Severity: MEDIUM
Suggested Fix
Filter out entries with None values in get_plan_bulk_with_cache before they are added to the cache. Alternatively, modify get_plan_bulk to not include tenants with invalid plans in its returned dictionary.
Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent.
Verify if this is a real issue. If it is, propose a fix; if not, explain why it's not
valid.
Location: api/services/billing_service.py#L365-L367
Potential issue: When a tenant's subscription plan fails validation, `get_plan_bulk`
returns `None` for that tenant. The `get_plan_bulk_with_cache` function then caches this
`None` value as the JSON string `"null"`. On subsequent requests, this cached `"null"`
is read, parsed back to `None`, and fails validation again. This results in a loop of
cache misses and repeated API calls for tenants with invalid data, defeating the purpose
of the cache and increasing API load.
Did we get this right? 👍 / 👎 to inform future reviews.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Benchmark PR from agentic-review-benchmarks#10