fix: remove hardcoded 48-character limit from text inputs#5
Conversation
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 3 potential issues.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
| return false | ||
| } | ||
| const headerData = data[0] | ||
| console.log('Checking batch inputs:', { dataLength: data.length, headerData }) |
There was a problem hiding this comment.
Debug console.log statement left in production code
Medium Severity
A console.log('Checking batch inputs:', { dataLength: data.length, headerData }) statement appears to be debug code that was accidentally committed. This will log user input data to the browser console in production, which clutters the console and potentially exposes user data.
| {type === 'number' && ( | ||
| <Input | ||
| type="number" | ||
| type="text" |
There was a problem hiding this comment.
Number input type incorrectly changed to text
Medium Severity
The input type for number fields was changed from type="number" to type="text". This breaks consistency with other similar components (chat-user-input.tsx, run-once/index.tsx) which still use type="number" for number inputs. Users lose native number input features like spinner controls and numeric keyboard on mobile devices.
| placeholder={name} | ||
| value={inputs[key] ? `${inputs[key]}` : ''} | ||
| onChange={(e) => { handleInputValueChange(key, e.target.value) }} | ||
| maxLength={max_length} |
There was a problem hiding this comment.
Inconsistent maxLength handling for paragraph inputs across components
Medium Severity
The PR adds maxLength={max_length} to the paragraph Textarea in chat-user-input.tsx, but the equivalent paragraph inputs in prompt-value-panel/index.tsx and run-once/index.tsx don't have this prop. This creates inconsistent behavior where a configured max_length for paragraph variables is enforced in one UI component but not in others.
Additional Locations (2)
1 participant
Benchmark PR from agentic-review-benchmarks#5
Note
Removes the implicit 48-character cap and ensures inputs only apply
max_lengthwhen explicitly configured.chat-user-input,prompt-value-panel, sharerun-once) now setmaxLengthfrom variablemax_lengthonly; no fallback; paragraph inputs also support configured limitsmax_lengthfromVAR_ITEM_TEMPLATE*; no auto-set on type change;buildPromptVariableFromInputno longer injects defaultsTEXT_MAX_LENGTH(256) cap when configuring text inputmaxLength; paragraph usesInfinity; file types unchangedvarItem.max_lengthdirectly; adds a small debug logmaxLengthfor paragraph; keep multi-file defaultsprompt-value-panelnumber field input type switched totextmaxLengthpresence/absence and related behaviorsWritten by Cursor Bugbot for commit fc5f36e. Configure here.