Skip to content

fix(web): enable JSON_OBJECT type support in console UI#2

Open
tomerqodo wants to merge 5 commits intocursor_full_base_fixweb_enable_json_object_type_support_in_console_ui_pr2from
cursor_full_head_fixweb_enable_json_object_type_support_in_console_ui_pr2
Open

fix(web): enable JSON_OBJECT type support in console UI#2
tomerqodo wants to merge 5 commits intocursor_full_base_fixweb_enable_json_object_type_support_in_console_ui_pr2from
cursor_full_head_fixweb_enable_json_object_type_support_in_console_ui_pr2

Conversation

@tomerqodo
Copy link
Copy Markdown

@tomerqodo tomerqodo commented Jan 25, 2026

Benchmark PR from agentic-review-benchmarks#2


Note

Enables configuring JSON object input variables directly in the config modal, including schema editing and validation.

  • Adds jsonObject type to the type selector (non-basic apps)
  • JSON Schema editor now handles/stores full schema (not just properties); placeholder updated to include type: object structure
  • On save, optionally allows empty schema; validates schema is valid JSON and has type: "object"
  • Removes wrapping via jsonObjectWrap; normalizes empty schema by omitting json_schema in payload
  • Adds localized error strings for invalid schema across all supported locales

Written by Cursor Bugbot for commit d631399. Configure here.

Copy link
Copy Markdown

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.

}
handlePayloadChange('json_schema')(JSON.stringify(res, null, 2))
handlePayloadChange('json_schema')(value)
return True
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Python boolean True used instead of JavaScript true

High Severity

The handleJSONSchemaChange callback returns True (Python syntax) instead of true (JavaScript syntax). Since True is not defined in JavaScript/TypeScript, this will throw a ReferenceError at runtime when a user enters valid JSON in the schema editor, causing the JSON schema change handler to fail completely.

Fix in Cursor Fix in Web

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants