fix(web): enable JSON_OBJECT type support in console UI#2
Open
Conversation
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
| } | ||
| handlePayloadChange('json_schema')(JSON.stringify(res, null, 2)) | ||
| handlePayloadChange('json_schema')(value) | ||
| return True |
There was a problem hiding this comment.
Python boolean True used instead of JavaScript true
High Severity
The handleJSONSchemaChange callback returns True (Python syntax) instead of true (JavaScript syntax). Since True is not defined in JavaScript/TypeScript, this will throw a ReferenceError at runtime when a user enters valid JSON in the schema editor, causing the JSON schema change handler to fail completely.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Benchmark PR from agentic-review-benchmarks#2
Note
Enables configuring JSON object input variables directly in the config modal, including schema editing and validation.
jsonObjecttype to the type selector (non-basic apps)properties); placeholder updated to includetype: objectstructuretype: "object"jsonObjectWrap; normalizes empty schema by omittingjson_schemain payloadWritten by Cursor Bugbot for commit d631399. Configure here.