fix: remove hardcoded 48-character limit from text inputs#5
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: fc5f36e4a6
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| return false | ||
| } | ||
| const headerData = data[0] | ||
| console.log('Checking batch inputs:', { dataLength: data.length, headerData }) |
There was a problem hiding this comment.
This adds a console.log in the share text-generation batch validator, which violates the repo’s frontend rule forbidding console statements and can leak user-supplied CSV header data in production. That can trip lint checks and expose sensitive inputs in the browser console; please remove it or gate it behind a debug-only logger.
Useful? React with 👍 / 👎.
| if (varItem.type === 'string') { | ||
| const maxLen = varItem.max_length || DEFAULT_VALUE_MAX_LEN | ||
| if (item[varIndex].length > maxLen) { | ||
| if (item[varIndex].length > varItem.max_length) { | ||
| moreThanMaxLengthVarName = varItem.name |
There was a problem hiding this comment.
The new comparison uses item[varIndex].length > varItem.max_length without checking for null/undefined. When existing prompt configs have max_length: null (common for “no limit”), JavaScript coerces null to 0, so any non-empty cell fails validation and batch runs are blocked. Please only enforce the check when max_length is a finite number or normalize null/undefined to “no limit.”
Useful? React with 👍 / 👎.
1 participant
Benchmark PR from agentic-review-benchmarks#5