refactor: always preserve marketplace search state in URL#9
Conversation
🤖 Augment PR SummarySummary: Refactors the plugins marketplace UI so search/filter state is always preserved in the URL query string. Changes:
Technical Notes: SSR prefetch still parses marketplace search params via 🤖 Was this summary useful? React with 👍 or 👎 |
![augmentcode[bot]](https://avatars.githubusercontent.com/in/1027498?s=60&v=4){kind=small}
| const queryState = useQueryState('category', marketplaceSearchParamsParsers.category) | ||
| const atomState = useAtom(activePluginTypeAtom) | ||
| return preserveSearchStateInQuery ? queryState : atomState | ||
| return useQueryState('tab', marketplaceSearchParamsParsers.category) |
There was a problem hiding this comment.
useActivePluginType() now reads/writes tab, but server parsing/prefetch (createLoader(marketplaceSearchParamsParsers) and params.category) still depends on the category param; this can make the selected category default to all and skip intended SSR prefetching.
Other Locations
web/app/components/plugins/marketplace/hydration-server.tsx:16web/app/components/plugins/marketplace/hydration-server.tsx:19web/app/components/plugins/marketplace/search-params.ts:6
🤖 Was this useful? React with 👍 or 👎
| const isSearchMode = !!searchPluginText | ||
| || filterPluginTags.length > 0 | ||
| || (searchMode ?? (!PLUGIN_CATEGORY_WITH_COLLECTIONS.has(activePluginType))) | ||
| || (searchMode ?? (PLUGIN_CATEGORY_WITH_COLLECTIONS.has(activePluginType))) |
There was a problem hiding this comment.
This condition appears inverted vs the preceding comment (“force the search mode for those categories” that don’t have collections); using PLUGIN_CATEGORY_WITH_COLLECTIONS.has(activePluginType) will force search mode for categories with collections instead.
🤖 Was this useful? React with 👍 or 👎
| } | ||
|
|
||
| export function usePluginPageContext(selector: (value: PluginPageContextValue) => any) { | ||
| export function usePluginPageContext(selector: any) { |
There was a problem hiding this comment.
usePluginPageContext now accepts selector: any; since useContextSelector expects a selector function, this removes the type guard that would prevent non-function values from causing runtime errors.
🤖 Was this useful? React with 👍 or 👎
2 participants
Benchmark PR from agentic-review-benchmarks#9