fix: remove hardcoded 48-character limit from text inputs#5
Conversation
🤖 Augment PR SummarySummary: Removes the hardcoded 48-character default limit from text inputs so values are only constrained when a variable’s
🤖 Was this summary useful? React with 👍 or 👎 |
![augmentcode[bot]](https://avatars.githubusercontent.com/in/1027498?s=60&v=4){kind=small}
| return false | ||
| } | ||
| const headerData = data[0] | ||
| console.log('Checking batch inputs:', { dataLength: data.length, headerData }) |
There was a problem hiding this comment.
Looks like a debug console.log was left in checkBatchInputs, which will spam browser logs for everyone using the shared text-generation page.
🤖 Was this useful? React with 👍 or 👎
| if (varItem.type === 'string') { | ||
| const maxLen = varItem.max_length || DEFAULT_VALUE_MAX_LEN | ||
| if (item[varIndex].length > maxLen) { | ||
| if (item[varIndex].length > varItem.max_length) { |
There was a problem hiding this comment.
item[varIndex].length > varItem.max_length can behave unexpectedly when max_length is null/undefined (e.g., null coerces to 0 and may fail every non-empty value). Consider explicitly skipping the max-length check unless max_length is a finite number.
🤖 Was this useful? React with 👍 or 👎
| {type === 'number' && ( | ||
| <Input | ||
| type="number" | ||
| type="text" |
There was a problem hiding this comment.
Switching the number variable input from type="number" to type="text" removes native numeric validation and the numeric keyboard on mobile, while handleInputValueChange stores the raw string. If this was only done to support maxLength, it may need additional guarding to prevent non-numeric values from being submitted.
🤖 Was this useful? React with 👍 or 👎
1 participant
Benchmark PR from agentic-review-benchmarks#5