Conversation
Copilot
AI
changed the title
[WIP] Add microsoft agent framework to SDK
Add Microsoft agent-framework adapter with shared module and separate lockfiles
Mar 4, 2026
g3force
requested changes
Mar 4, 2026
Copilot
AI
changed the title
Add Microsoft agent-framework adapter with shared module and separate lockfiles
Add Microsoft agent-framework adapter with shared module and three independent lockfiles
Mar 4, 2026
g3force
requested changes
Mar 4, 2026
Copilot
AI
changed the title
Add Microsoft agent-framework adapter with shared module and three independent lockfiles
Add Microsoft agent-framework adapter with shared module and independent projects
Mar 4, 2026
g3force
requested changes
Mar 4, 2026
Copilot stopped work on behalf of
g3force due to an error
March 4, 2026 10:21
Copilot
AI
changed the title
Add Microsoft agent-framework adapter with shared module and independent projects
Fix publish workflow: add msaf/shared publishing, fix packages-dir, read Python version from pyproject.toml
Mar 4, 2026
g3force
requested changes
Mar 4, 2026
adk/agenticlayer/config.py
Outdated
| """ | ||
| Configuration parsing for sub-agents and tools. | ||
| Parses JSON configurations to create RemoteA2aAgents, AgentTools and McpToolsets. | ||
| Re-exported from agenticlayer_shared for backward compatibility. |
Contributor
There was a problem hiding this comment.
We do not care for backwards compatibility for now. There is only one client and we'll refactor that afterwards. Consider this for all files that re-export currently.
Contributor
Author
There was a problem hiding this comment.
Done in 72f1cdf. Deleted all pure re-export files from adk/agenticlayer/: config.py, constants.py, loguru_config.py, otel_starlette.py, and __init__.py. All consumers now import directly from agenticlayer.* (the renamed shared namespace).
Contributor
There was a problem hiding this comment.
Don't use a shared namespace. Use a sub package for the implementations instead.
Copilot
AI
changed the title
Fix publish workflow: add msaf/shared publishing, fix packages-dir, read Python version from pyproject.toml
Fix publish workflow: matrix build for all packages; rename shared module; remove backward-compat re-exports
Mar 4, 2026
Co-authored-by: g3force <779094+g3force@users.noreply.github.com>
Co-authored-by: g3force <779094+g3force@users.noreply.github.com>
Co-authored-by: g3force <779094+g3force@users.noreply.github.com>
Co-authored-by: g3force <779094+g3force@users.noreply.github.com>
Co-authored-by: g3force <779094+g3force@users.noreply.github.com>
…le and packages-dir Co-authored-by: g3force <779094+g3force@users.noreply.github.com>
…blish workflow Co-authored-by: g3force <779094+g3force@users.noreply.github.com>
72f1cdf to
1c85fda
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The publish workflow only published the
adkpackage, had a brokenpackages-dir, and hardcoded the Python version. Additionally, the shared module had an unnecessarily verbose name andadkcarried redundant backward-compatibility re-export files.Changes
publish.ymlstrategy.matrixover[shared, adk, msaf]withmax-parallel: 1, eliminating the duplicated build/publish steps — each matrix job handles version-bump → build → publish for its packagepython-version-filereads fromadk/pyproject.tomlpackages-dir: <pkg>/diston every publish stepcopilot-setup-steps.ymlpython-version: "3.14"replaced withpython-version-file: "adk/pyproject.toml"shared/module rename:agenticlayer_shared→agenticlayershared/agenticlayer_shared/→shared/agenticlayer/(namespace package, no__init__.py)otel.py→_otel.pywithin shared to avoid a namespace conflict withadk/agenticlayer/otel.pyshared/pyproject.tomlpackages to["agenticlayer"]agenticlayer_shared.*updated toagenticlayer.*(oragenticlayer._otel) acrossadk/,msaf/, and their testsadk/agenticlayer/— removed backward-compat re-exportsconfig.py,constants.py,loguru_config.py,otel_starlette.py,__init__.pyagenticlayernamespaceadk/pyproject.tomlandmsaf/pyproject.tomlpythonpathextended with"../shared"for namespace package resolutionmsafmypy config updated:namespace_packages = true,explicit_package_bases = true,mypy_path = [".", "../shared"]msaf/Makefilemypy --no-incrementalto avoid a mypy caching issue with transitive google namespace packagesOriginal prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.