Skip to content

Fix publish workflow: matrix build for all packages; rename shared module; remove backward-compat re-exports#31

Merged
g3force merged 11 commits intomainfrom
copilot/add-microsoft-agent-framework
Mar 4, 2026
Merged

Fix publish workflow: matrix build for all packages; rename shared module; remove backward-compat re-exports#31
g3force merged 11 commits intomainfrom
copilot/add-microsoft-agent-framework

Conversation

Copy link
Contributor

Copilot AI commented Mar 3, 2026

The publish workflow only published the adk package, had a broken packages-dir, and hardcoded the Python version. Additionally, the shared module had an unnecessarily verbose name and adk carried redundant backward-compatibility re-export files.

Changes

  • publish.yml

    • Refactored to a strategy.matrix over [shared, adk, msaf] with max-parallel: 1, eliminating the duplicated build/publish steps — each matrix job handles version-bump → build → publish for its package
    • python-version-file reads from adk/pyproject.toml
    • Explicit packages-dir: <pkg>/dist on every publish step
  • copilot-setup-steps.yml

    • python-version: "3.14" replaced with python-version-file: "adk/pyproject.toml"
  • shared/ module rename: agenticlayer_sharedagenticlayer

    • Renamed shared/agenticlayer_shared/shared/agenticlayer/ (namespace package, no __init__.py)
    • Renamed otel.py_otel.py within shared to avoid a namespace conflict with adk/agenticlayer/otel.py
    • Updated shared/pyproject.toml packages to ["agenticlayer"]
    • All imports from agenticlayer_shared.* updated to agenticlayer.* (or agenticlayer._otel) across adk/, msaf/, and their tests
  • adk/agenticlayer/ — removed backward-compat re-exports

    • Deleted pure re-export files: config.py, constants.py, loguru_config.py, otel_starlette.py, __init__.py
    • All consumers now import directly from the agenticlayer namespace
  • adk/pyproject.toml and msaf/pyproject.toml

    • pytest pythonpath extended with "../shared" for namespace package resolution
    • msaf mypy config updated: namespace_packages = true, explicit_package_bases = true, mypy_path = [".", "../shared"]
  • msaf/Makefile

    • mypy --no-incremental to avoid a mypy caching issue with transitive google namespace packages
Original prompt

This section details on the original issue you should resolve

<issue_title>Add microsoft-agent-framework</issue_title>
<issue_description>Add a second agent framework to this sdk: https://github.com/microsoft/agent-framework

Use the Python API and implement the same SDK API as for ADK. Extract common logic to a new shared module, containing only framework independent code.</issue_description>

Comments on the Issue (you are @copilot in this section)


✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

Copilot AI changed the title [WIP] Add microsoft agent framework to SDK Add Microsoft agent-framework adapter with shared module and separate lockfiles Mar 4, 2026
@g3force g3force marked this pull request as ready for review March 4, 2026 07:29
Copilot AI changed the title Add Microsoft agent-framework adapter with shared module and separate lockfiles Add Microsoft agent-framework adapter with shared module and three independent lockfiles Mar 4, 2026
Copilot AI changed the title Add Microsoft agent-framework adapter with shared module and three independent lockfiles Add Microsoft agent-framework adapter with shared module and independent projects Mar 4, 2026
Copilot AI changed the title Add Microsoft agent-framework adapter with shared module and independent projects Fix publish workflow: add msaf/shared publishing, fix packages-dir, read Python version from pyproject.toml Mar 4, 2026
"""
Configuration parsing for sub-agents and tools.
Parses JSON configurations to create RemoteA2aAgents, AgentTools and McpToolsets.
Re-exported from agenticlayer_shared for backward compatibility.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We do not care for backwards compatibility for now. There is only one client and we'll refactor that afterwards. Consider this for all files that re-export currently.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done in 72f1cdf. Deleted all pure re-export files from adk/agenticlayer/: config.py, constants.py, loguru_config.py, otel_starlette.py, and __init__.py. All consumers now import directly from agenticlayer.* (the renamed shared namespace).

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't use a shared namespace. Use a sub package for the implementations instead.

Copilot AI changed the title Fix publish workflow: add msaf/shared publishing, fix packages-dir, read Python version from pyproject.toml Fix publish workflow: matrix build for all packages; rename shared module; remove backward-compat re-exports Mar 4, 2026
Copilot AI and others added 5 commits March 4, 2026 15:43
Co-authored-by: g3force <779094+g3force@users.noreply.github.com>
Co-authored-by: g3force <779094+g3force@users.noreply.github.com>
Co-authored-by: g3force <779094+g3force@users.noreply.github.com>
Co-authored-by: g3force <779094+g3force@users.noreply.github.com>
Copilot AI and others added 5 commits March 4, 2026 15:43
Co-authored-by: g3force <779094+g3force@users.noreply.github.com>
…le and packages-dir

Co-authored-by: g3force <779094+g3force@users.noreply.github.com>
…blish workflow

Co-authored-by: g3force <779094+g3force@users.noreply.github.com>
@g3force g3force force-pushed the copilot/add-microsoft-agent-framework branch from 72f1cdf to 1c85fda Compare March 4, 2026 14:43
@g3force g3force merged commit e51c237 into main Mar 4, 2026
2 checks passed
@g3force g3force deleted the copilot/add-microsoft-agent-framework branch March 4, 2026 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add microsoft-agent-framework

2 participants