feat: support explicit package commands#323
Open
lsaether wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #296 by allowing package-based distributions to declare the executable command separately from the installable package name.
This adds optional
cmdsupport for package distributions so the registry can represent launch shapes like:instead of assuming the package name is always the executable to run.
Why
Some packages publish under one distribution name but expose a differently named ACP executable. Issue #296 describes a PyPI package where the package name differs from the CLI command that should be launched.
This PR keeps existing behavior for manifests without
cmd, while adding a way to express the explicit-command case.Changes
cmdto package distribution schema/docs.uvx, useuvx --from <package> <cmd> <args...>whencmdis present.npx, use equivalent explicit package-command launch behavior whencmdis present.cmdis omitted.cmdhandling and package specs with extras/version markers.Follow-up
If this tooling change is accepted, I plan to follow up with a separate PR adding Hermes Agent to the registry.
Hermes is blocked on this same package-vs-executable distinction: the installable package is
hermes-agent[acp], while the ACP entrypoint ishermes-acp/hermes acp. Keeping that agent entry separate should make this PR easier to review as the generic registry capability requested in #296.Validation
uv run --with ruff ruff format --check .github/workflowsuv run --with ruff ruff check .github/workflowsuv run --with pytest pytest .github/workflows/tests/ -q→118 passeduv run --with jsonschema .github/workflows/build_registry.py --dry-run→ validated 36 agents successfullygit diff --check