Skip to content

fix: update install.sh doctor readiness parsing to use current blockers schema #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
avifenesh merged 3 commits into from
May 25, 2026
Merged

fix: update install.sh doctor readiness parsing to use current blockers schema #9

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2f6e8f7
fix: update install.sh doctor readiness parsing to use current blocke…
vi70x3 May 25, 2026
bd9471c
fix: harden jq parsing in run_doctor against missing/invalid blockers…
vi70x3 May 25, 2026
b0a1eaf
fix: restore install.sh executable bit
avifenesh May 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 10 additions & 7 deletions install.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -443,26 +443,29 @@ run_doctor() {
fi

if command -v jq >/dev/null 2>&1 && printf '%s' "${out}" | jq -e . >/dev/null 2>&1; then
local ready
ready="$(printf '%s' "${out}" | jq -r '.readiness.ready // false')"
local blockers
blockers="$(printf '%s' "${out}" | jq -r '.readiness.blockers | if type == "array" then length else -1 end')"
printf '%s\n' "${out}" | jq -r '
.readiness as $r |
"ready: \($r.ready)\n" +
((($r.checks // []) | map(" - \(.name): \(.status)\(if .detail then " (\(.detail))" else "" end)") | join("\n")))
"ready: \($r.blockers | type == "array" and length == 0)\n" +
((($r.blockers // []) | map(" - \(.)") | join("\n")))
'
if [[ "${ready}" == "true" ]]; then
if [[ "${blockers}" -eq 0 ]]; then
log_ok "doctor reports ready"
elif [[ "${blockers}" -eq -1 ]]; then
log_fail "doctor output missing blockers field — unexpected JSON structure"
return 1
else
log_fail "doctor reports NOT ready"
while IFS= read -r line; do
FAILED_CHECKS+=("${line}")
done < <(printf '%s' "${out}" | jq -r '.readiness.checks[]? | select(.status != "ok") | "\(.name): \(.detail // .status)"')
done < <(printf '%s' "${out}" | jq -r '.readiness.blockers[]?')
return 1
fi
else
# Raw fallback.
printf '%s\n' "${out}"
if printf '%s' "${out}" | grep -qiE '"ready"[[:space:]]*:[[:space:]]*true|ready: true'; then
if printf '%s' "${out}" | grep -qiE '"blockers"[[:space:]]*:[[:space:]]*\[\]'; then
log_ok "doctor reports ready (raw)"
else
log_fail "doctor did not report ready (install jq for a structured summary)"
Expand Down
Loading