docs(neovim): fix plugin repo name and add missing setup() call#628
docs(neovim): fix plugin repo name and add missing setup() call#628shawilly wants to merge 1 commit intoagent-sh:mainfrom
Conversation
The Neovim install snippets referenced a non-existent `agnix.nvim` repo.
The correct plugin identifier is `agent-sh/agnix`, and `require("agnix").setup()`
is required for the plugin to initialize.
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses critical inaccuracies in the Neovim plugin installation documentation. The changes ensure that users can correctly install and initialize the Highlights
Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request correctly updates the Neovim plugin repository name and adds the required setup() call in the documentation. The changes are accurate and fix the reported issue. I've provided a couple of suggestions to make the lazy.nvim code snippets more concise by leveraging the plugin manager's features. Additionally, please note that website/docs/editor-integration.md and its versioned copy also contain the outdated information and could be updated in this PR for consistency.
Note: Security Review has been skipped due to the limited scope of the PR.
| | **VS Code** | [VS Code Marketplace](https://marketplace.visualstudio.com/items?itemName=avifenesh.agnix) | | ||
| | **JetBrains** | [JetBrains Marketplace](https://plugins.jetbrains.com/plugin/30087-agnix) | | ||
| | **Neovim** | `{ "agent-sh/agnix.nvim" }` | | ||
| | **Neovim** | `{ "agent-sh/agnix", config = function() require("agnix").setup() end }` | |
There was a problem hiding this comment.
The lazy.nvim installation snippet can be made more concise. Instead of using a config function to call setup(), you can use the opts property. lazy.nvim will automatically call the setup function with the provided options. Using opts = {} is shorter and more idiomatic for this case.
| | **Neovim** | `{ "agent-sh/agnix", config = function() require("agnix").setup() end }` | | |
| | **Neovim** | `{ "agent-sh/agnix", opts = {} }` | |
|
@shawilly Thanks! |
There was a problem hiding this comment.
Pull request overview
Updates Neovim installation documentation to reference the correct plugin repository and ensure the plugin is initialized properly.
Changes:
- Fix Neovim plugin repo identifier in
README.mdeditor install table and add the requiredrequire("agnix").setup()init call. - Fix Neovim plugin repo identifier in
editors/neovim/README.mdfor lazy.nvim, packer.nvim, and vim-plug snippets.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| README.md | Updates the Neovim install snippet in the editor extensions table to use agent-sh/agnix and call setup(). |
| editors/neovim/README.md | Updates plugin manager snippets to point to agent-sh/agnix instead of the old repo name. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| | **VS Code** | [VS Code Marketplace](https://marketplace.visualstudio.com/items?itemName=avifenesh.agnix) | | ||
| | **JetBrains** | [JetBrains Marketplace](https://plugins.jetbrains.com/plugin/30087-agnix) | | ||
| | **Neovim** | `{ "agent-sh/agnix.nvim" }` | | ||
| | **Neovim** | `{ "agent-sh/agnix", config = function() require("agnix").setup() end }` | |
There was a problem hiding this comment.
README still links to https://github.com/agent-sh/agnix.nvim in the header line (earlier in the file), which appears to be the same non-existent repo this PR is fixing in the install snippet. Update that link to the correct Neovim plugin location so users don’t hit a broken URL.
| | **Neovim** | `{ "agent-sh/agnix", config = function() require("agnix").setup() end }` | | |
| | **Neovim** | [Neovim plugin (`agent-sh/agnix`)](https://github.com/agent-sh/agnix/tree/main/editors/nvim) – `{ "agent-sh/agnix", config = function() require("agnix").setup() end }` | |
| { | ||
| 'avifenesh/agnix.nvim', | ||
| 'agent-sh/agnix', | ||
| ft = { 'markdown', 'json' }, |
There was a problem hiding this comment.
In the lazy.nvim snippet, ft = { 'markdown', 'json' } can prevent the plugin from loading when opening other agnix-supported files first (e.g. .cursorrules), so the BufReadPost auto-attach logic never runs. Consider loading on a general event (e.g. BufReadPre/BufNewFile) and letting the plugin’s internal is_agnix_file gate decide when to attach.
| ft = { 'markdown', 'json' }, | |
| event = { 'BufReadPre', 'BufNewFile' }, |
|
Thank you for this contribution @shawilly! Since we haven't heard back and this is a straightforward docs fix that's needed, I've taken the liberty of creating #645 with your changes (with co-author credit). The new PR is rebased on the current main branch and ready to merge. Your contribution is appreciated! 🙏 |
|
@avifenesh thank you, very considerate as this had left my mind with some busy times at the ol' 9-5. Thank you for the update and vim support! |
The Neovim install snippets referenced a non-existent
agnix.nvimrepo.The correct plugin identifier is
agent-sh/agnix, andrequire("agnix").setup()is required for the plugin to initialize.Summary
agent-sh/agnix.nvim→agent-sh/agnix)require("agnix").setup()call to the README.md snippetType of Change
Checklist
cargo fmt && cargo clippypassesRelated Issues
[BUG] neovim installation docs: wrong plugin repo name and missing setup() call in install snippets
Test Plan
{ "agent-sh/agnix", config = function() require("agnix").setup() end }to a lazy.nvim config