fix: make mobile assistant fullscreen#106
Open
erzaehlsalex wants to merge 3 commits into
Open
Conversation
flore2003
force-pushed
the
fix/mobile-assistant-fullscreen
branch
from
9059e08 to
6f61a1a
Compare
|
@flore2003 is attempting to deploy a commit to the Silica Team on Vercel. A member of the Team first needs to authorize it. |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
flore2003
force-pushed
the
fix/mobile-assistant-fullscreen
branch
from
6f61a1a to
4dbe209
Compare
Member
|
This is still a bit wonky, I might take a shot at this tomorrow |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Before this change, opening the assistant from the mobile sidebar left the sidebar open and the assistant appeared constrained to the sidebar-sized sheet instead of taking over the screen.
onOpenhook to the assistant trigger slot so themes can coordinate surrounding UI.Test plan
npm run typecheck --workspace @silicajs/assistantnpm run typecheck --workspace @silicajs/corenpm run typecheck --workspace @silicajs/theme-amethyst